[53584] Fix Portuguese languages mapping #15072
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://community.openproject.org/wp/53584 https://community.openproject.org/wp/53586 When making Portuguese Brazilian and Portuguese Portugal translations apart from each other in https://community.openproject.org/wp/53374, we missed that the root key in the `pt-BR.yml` and `pt-PT.yml` files is still `pt`. The backend is gracefully falling back to the `pt` translations but the frontend just fails to translate and falls back to the English strings, leading to mixed English and Portuguese in the user interface. A script fixes the root key in the `pt-BR.yml` and `pt-PT.yml` files. This script is executed each time the translations are updated from crowdin.
mereghost
approved these changes
Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://community.openproject.org/wp/53584
https://community.openproject.org/wp/53586
When making Portuguese Brazilian and Portuguese Portugal translations apart from each other in https://community.openproject.org/wp/53374, we missed that the root key in the
pt-BR.ymlandpt-PT.ymlfiles is stillpt. The backend is gracefully falling back to thepttranslations but the frontend just fails to translate and falls back to the English strings, leading to mixed English and Portuguese in the user interface.A script fixes the root key in the
pt-BR.ymlandpt-PT.ymlfiles. This script is executed each time the translations are updated from crowdin.