Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[51772] Odd spacing in Notification and Email Reminder personal setting pages (2) #15076

Conversation

HDinger
Copy link
Contributor

@HDinger HDinger commented Mar 22, 2024

Changes affect the personal notification settings page and the personal email reminders settings page:

  • Let the headers span the complete width of the screen
  • Add more spacing between the sections

Further, this PR fixes some class names that were wrongly renamed.

https://community.openproject.org/projects/openproject/work_packages/51772/activity

Notification settings

Before
Bildschirmfoto 2024-03-22 um 09 15 49

After
Bildschirmfoto 2024-03-22 um 09 11 30

Email reminders

Before
Bildschirmfoto 2024-03-22 um 09 16 00

After
Bildschirmfoto 2024-03-22 um 09 11 38

Copy link
Contributor

@psatyal psatyal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We only really needed a small but visible difference between the top and the bottom to be able to better visually group things; your changes achieve this so I'd say this definitely does it, thanks!

Copy link
Contributor

@bsatarnejad bsatarnejad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@HDinger HDinger merged commit 62c7d0e into dev Mar 25, 2024
8 checks passed
@HDinger HDinger deleted the bug/51772-odd-spacing-in-notification-and-email-reminder-personal-setting-pages-2 branch March 25, 2024 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants