Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix test fail caused by stale shared object #15224

Merged
merged 1 commit into from
Apr 11, 2024

Conversation

toy
Copy link
Contributor

@toy toy commented Apr 11, 2024

Not sure what is the best way, following fails:

rspec './spec/features/work_packages/progress_modal_spec.rb[1:4:1:1:1,1:6:1:1,1:6:2:1]' --seed 33667

@toy toy requested a review from aaron-contreras April 11, 2024 12:00
Copy link
Contributor

@aaron-contreras aaron-contreras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine 👍

Very nice find!

@aaron-contreras
Copy link
Contributor

I would just say to change the base branch to release/14.0 and then merge back the release branch into dev

@toy toy changed the base branch from dev to release/14.0 April 11, 2024 13:59
Not sure what is the best way, following fails:

```shell
rspec './spec/features/work_packages/progress_modal_spec.rb[1:4:1:1:1,1:6:1:1,1:6:2:1]' --seed 33667
```
@toy toy force-pushed the fix-progress-modal-flaky-test branch from c7859e8 to 81f0499 Compare April 11, 2024 14:00
@toy toy merged commit de0873b into release/14.0 Apr 11, 2024
9 checks passed
@toy toy deleted the fix-progress-modal-flaky-test branch April 11, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants