Allow shared users to be set as accountable/responsible as well #15249
Conversation
klaustopher
force-pushed
the
shared-user-as-accountable
branch
from
88118cf to
d15d38c
Compare
| @@ -67,7 +67,6 @@ class ProjectsAPI < ::API::OpenProjectAPI | |||
| mount ::API::V3::Projects::UpdateFormAPI | |||
|
|
|||
| mount API::V3::Projects::AvailableAssigneesAPI | |||
| mount API::V3::Projects::AvailableResponsiblesAPI | |||
There was a problem hiding this comment.
Whooops, sorry for overlooking and thanks for fixing. I did not restart my server after removing the class. I wonder why the tests did not fail when autoloading? 🤔
There was a problem hiding this comment.
Yeah, sorry for stepping over the reviewer boundaries here but it was so straight forward that it seemed weird to note it down instead.
What was weird is that the CI didn't run on your commit d15d38c before otherwise it would have informed you already.
| @@ -67,7 +67,6 @@ class ProjectsAPI < ::API::OpenProjectAPI | |||
| mount ::API::V3::Projects::UpdateFormAPI | |||
|
|
|||
| mount API::V3::Projects::AvailableAssigneesAPI | |||
| mount API::V3::Projects::AvailableResponsiblesAPI | |||
There was a problem hiding this comment.
Yeah, sorry for stepping over the reviewer boundaries here but it was so straight forward that it seemed weird to note it down instead.
What was weird is that the CI didn't run on your commit d15d38c before otherwise it would have informed you already.
The
responsiblefield still used the project specific autocompleter. This was moved to the work package when the package was persisted. I found that theavailable_responsiblesAPI endpoint returns the same data as theavailable_assigneesendpoint. Since it is not used in any places, I have also removed the endpointFixes https://community.openproject.org/projects/openproject/work_packages/51551