Bug/53344 cannot modify a query that was created by a deleted user #15258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dombesz
force-pushed
the
bug/53344-cannot-modify-a-query-that-was-created-by-a-deleted-user
branch
4 times, most recently
from
bb19231 to
2c4fa94
Compare
…s been made private https://community.openproject.org/work_packages/53344 This covers an edge case, when an adminitrator makes another user's query private. In this case, the query becomes accessible only by its creator. We will try to reload the query after the save happens, but since the query is not accessible, a confusing error message is rendered. In order to avoid this error message, we are redirecting the admin to the default query page if the query becomes private and not accessible.
dombesz
force-pushed
the
bug/53344-cannot-modify-a-query-that-was-created-by-a-deleted-user
branch
from
2c4fa94 to
8234537
Compare
cbliard
approved these changes
Apr 19, 2024
cbliard
deleted the
bug/53344-cannot-modify-a-query-that-was-created-by-a-deleted-user
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://community.openproject.org/wp/53344
Addresses the issue reported here.
When an admin makes another user's public query private, it will no longer have access to it. Currently the logic is to reload the changed query, but since the admin user doesn't have access to the query anymore, the page renders a permission error.
This can be a confusing behaviour, and this PR changes the logic to navigate the browser to the default work packages view, instead of refreshing the inaccessible query.