Remove duplicate filters in BaseQuery#where

[oliverguenther]

#15162 (comment)

It was not what I assumed, but the new TimeFilter did only set a value for the filters and thus it had an empty value in the select. It works now and also uses the proper translation for the displayed values.

The issue that the number was to high is that we are adding the project filter twice:

    query = ParamsToQueryService.new(Meeting, current_user).call(params)
    # ↳ When there is a project_id filter in the URL this is added as a filter to the query

    query = apply_default_filter_if_none_given(query)

    if @project
      query.where("project_id", '=', @project.id)
      # ↳ This adds the filter regardless and we end up with the ProjectFilter twice in the list
    end

I have added a workaround in 222fef2 but I'm not sure if we should rather fix the underlying problem.

[klaustopher]

LGTM

[klaustopher]

With this removed we can also remove the hack in

openproject/app/components/filters_component.rb

Lines 60 to 66 in d74ba41

	def filters_count
	@filters_count ||= query
	.filters
	.map(&:class)
	.uniq
	.count
	end

[klaustopher]

That was an easy fix