Feature/49060 group agenda items with sections #15291
Conversation
… and drop support yet
…ng of code required
frontend/src/stimulus/controllers/dynamic/meeting-section-form.controller.ts
Outdated
Show resolved
Hide resolved
modules/meeting/app/contracts/meeting_sections/update_contract.rb
Outdated
Show resolved
Hide resolved
| @@ -86,42 +86,89 @@ def update_sidebar_participants_form_component_via_turbo_stream(meeting: @meetin | |||
| component: Meetings::Sidebar::ParticipantsFormComponent.new( | |||
| meeting: | |||
| ), | |||
| status: :bad_request | |||
| status: :bad_request # TODO: why bad_request? | |||
There was a problem hiding this comment.
We want to ensure a non-ok HTTP response so that the modal doesn't auto-close after the form submission. Do you have a specific other status in mind?
There was a problem hiding this comment.
This would make sense to me if there's a form which should show from validations - but in this case I don't see that. Additionally, having a static "bad_request" - even for successful submissions - seems like a misuse of the status.
However, I just saw that this method (update_sidebar_participants_form_component_via_turbo_stream) is not used at all. Only update_sidebar_participants_component_via_turbo_stream is called within the controller.
I would therefore remove update_sidebar_participants_form_component_via_turbo_stream. @oliverguenther Or do I miss something here?
There was a problem hiding this comment.
Yes I think it can be removed, it's a remnant from before the time we rendered the dialog/form separately
…n the section controller in order to get a homogenous behaviour
https://community.openproject.org/work_packages/49060