Feature/54464 snappier progress popover #15383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ulferts
force-pushed
the
feature/54464-snappier-progress-popover
branch
from
1f10742 to
7b62365
Compare
ulferts
force-pushed
the
feature/54464-snappier-progress-popover
branch
from
7b62365 to
c4ffc69
Compare
| // TODO: Ideally morphing in this single controller should not be necessary. | ||
| // Turbo supports morphing, by adding the <turbo-frame refresh="morph"> attribute. | ||
| // However, it has a bug, and it doesn't morphs when reloading the frame via javascript. | ||
| // See https://github.com/hotwired/turbo/issues/1161 . Once the issue is solved, we can remove | ||
| // this code and just use <turbo-frame refresh="morph"> instead. | ||
| this.frameMorphRenderer = (event:CustomEvent<TurboBeforeFrameRenderEventDetail>) => { | ||
| event.detail.render = (currentElement:HTMLElement, newElement:HTMLElement) => { | ||
| morphdom(currentElement, newElement, { childrenOnly: true }); | ||
| Idiomorph.morph(currentElement, newElement, { ignoreActiveValue: true }); |
There was a problem hiding this comment.
Well well well... Seems they've thought of this already 😆
aaron-contreras
approved these changes
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO
applieddata-turbo-permanentattribute on focused field in the progress popover and prevented a DOM element with such an attribute from being updated. This prevents inputs from being eaten up.Using an attribute is in line with how Turbo does it so once the Turbo-bug on js triggered frame updates is fixed, it should still work out of the box.
That path was abandoned again as idiomorph has a flag to be passed in when morphing
ignoreActiveValuewhich, while documentation is sparse, seems to provide the behaviour we want out of the box.turbo:before-frame-renderfrom setup.ts. It is only necessary for js triggered updates in the preview controller and not on a general level.https://community.openproject.org/wp/54464