fix[Op#52098]: Invalidate form validity when direct upload is too large #15411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See: https://developer.mozilla.org/en-US/docs/Web/API/HTMLObjectElement/setCustomValidity On direct upload, client side JQuery overrides the form submission to the _"direct"_ storage provider. This PR intercepts this submission by attaching form validity via [`HTMLObjectElement.setCustomValidity()`](https://developer.mozilla.org/en-US/docs/Web/API/HTMLObjectElement/setCustomValidity) ---- Co-authored-by: Eric Schubert <e.schubert@openproject.com>
akabiru
force-pushed
the
bug/52098-misleading-error-message-ifc-direct-upload
branch
from
994ba4d to
43dd5e5
Compare
Kharonus
approved these changes
Apr 30, 2024
akabiru
added a commit
that referenced
this pull request
May 14, 2024
…-ifc-direct-upload fix[Op#52098]: Invalidate form validity when direct upload is too large
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://community.openproject.org/wp/52098
Follows #15280
On direct upload, client side JQuery overrides the form submission to the "direct" storage provider. This PR intercepts this submission by attaching form validity via
HTMLObjectElement.setCustomValidity()See: https://developer.mozilla.org/en-US/docs/Web/API/HTMLObjectElement/setCustomValidity
ifc-direct-upload-fix.mp4