Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possilbe having email like 12775518238@qq.com #15515

Merged
merged 1 commit into from
May 14, 2024

Conversation

Eric-Guo
Copy link
Contributor

No description provided.

Copy link
Contributor

@dombesz dombesz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Eric-Guo for the contribution. 👏
Usually we like to have tests included with PRs, san you please add a test for this fix?

app/controllers/concerns/member_helper.rb Show resolved Hide resolved
@Eric-Guo Eric-Guo force-pushed the digital_start_email branch from 49377ed to 1cebeb1 Compare May 10, 2024 11:50
@Eric-Guo
Copy link
Contributor Author

Eric-Guo commented May 10, 2024

@dombesz Guess I can reuse one so I don't need to write new one. 😎

Any way the test case is added.

@Eric-Guo Eric-Guo force-pushed the digital_start_email branch 2 times, most recently from 8584c36 to a73ed19 Compare May 11, 2024 06:12
@Eric-Guo Eric-Guo requested a review from dombesz May 11, 2024 11:53
@Eric-Guo Eric-Guo force-pushed the digital_start_email branch from a73ed19 to 947e7ea Compare May 14, 2024 13:16
@Eric-Guo Eric-Guo force-pushed the digital_start_email branch from 947e7ea to 9a7040e Compare May 14, 2024 13:19
@Eric-Guo Eric-Guo requested a review from dombesz May 14, 2024 13:34
Copy link
Contributor

@dombesz dombesz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Eric-Guo !👍

@dombesz dombesz merged commit 135e04a into opf:dev May 14, 2024
8 checks passed
@Eric-Guo Eric-Guo deleted the digital_start_email branch May 16, 2024 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants