Use "New section" as placeholder, empty title as the hidden/builtin title

[oliverguenther]

https://community.openproject.org/work_packages/55111

[cbliard]

@oliverguenther
The placeholder text is "New section" and yet when creating the section without having entered any name, the section title is "Untitled"
I would have expected "New section" as section title as it is what the placeholder text was.
Is it expected?

[oliverguenther]

@oliverguenther The placeholder text is "New section" and yet when creating the section without having entered any name, the section title is "Untitled" I would have expected "New section" as section title as it is what the placeholder text was. Is it expected?

Good catch. Indeed this should be changed to make it consistent

[github-actions]

	1 Warning
⚠️	This PR has migration-related changes on a release branch. Ping @opf/operations

Generated by 🚫 Danger

Additional changes since your review

[cbliard]

It does not seem to work as expected: it should not allow creating a section without a title. Yet it does.

Also there are some strange things: in MeetingSectionsController, the meeting section is initially created with title "New section", but this one is not shown in the returned HTML.

It's because in modules/meeting/app/forms/meeting_sections/title.rb, the title is not used if it is the default title. Why not just use the given value?

When saving, it then accepts the empty value, contrary to the text comment in create contract.

The check in create contract is not run. To ensure the title is present this check should also be done in the update contract of meeting section.

[cbliard]

This check should be replicated in the UpdateContract to prevent users from emptying the section title.

[cbliard]

The previous issue is fixed: when trying to create a section with a blank title, it now displays "Title can't be blank"

I saw 3 other issues, one of which is intentional:

• "+ Add" button turning blank
• section existing with empty title when reloading the page
• incorrect place holder text when editing an existing section having an empty title

---

"+ Add" button turning blank

Not sure why, but when adding a new section, a new work package or a new agenda item, the green "+ Add" button at the bottom of the page is turning blank.

Is it because it is in a disabled state?

---

Section existing with empty title when reloading the page

steps:

1. click "+ Add" > click "Section"
   => a section is added, prompting for a title
2. reload the page
   => the section is there, with an empty title

This is the one Oliver explained me that it is kinda intentional, as the section is already created when it is prompting for a title.
I'm just putting it here for acknowledgement.

---

Incorrect place holder text when editing an existing section having an empty title

Steps:

1. Add a section with a proper name
2. Edit the first section name (the one being displayed as "Untitled section")

• Actual: the placeholder is "Title"
• Expected: the placeholder should be "New section"

[jjabari-op]

@cbliard thank you for your remarks:

Towards No 1:

Indeed, the disabled state looks not correctly styled - I try to figure out what is causing this

Towards No 2:

Yes, this is intentional

Towards No 3:

Fixed

[cbliard]

Sounds good now

[jjabari-op]

@cbliard towards No 1 again: var(--button-primary-bgColor-disabled) seems not to be defined anymore according to my chrome inspector:

I create a bug for that