[55132] Disabled Primer button styles not displayed correctly #15601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@HDinger I've checked out this branch, updated all packages (npm and bundle), restarted the rails and angular server. The button is now completely invisible when disabled (Chrome and Firefox). The button is rendered but all white as the background. I'm using the default theme ("Light"). In "Ligh High Contrast" the button seems to be correctly styled however! |
HDinger
force-pushed
the
bug/55132-disabled-primer-button-styles-not-displayed-correctly
branch
from
b1d6702 to
8645918
Compare
|
@jjabari-op Good catch, I forgot to add the defaults, for the case that no custom style is configured. 👍 Could you please try again? |
HDinger
deleted the
bug/55132-disabled-primer-button-styles-not-displayed-correctly
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use darker version for disabled primary button style and set border as well
https://community.openproject.org/projects/openproject/work_packages/55132/activity
Before
After