Fix/limit schedule reminder mail jobs #15602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mereghost , this is the PR that will add the limits you asked for in #15573. I tested the behaviour locally and it seems to work as expected. The job is retried twice (with a 5 minute backoff) and then discarded. 5 minutes after that, the next job is scheduled according to the cron tab. |
ulferts
force-pushed
the
fix/limit_schedule_reminder_mail_jobs
branch
from
f978191 to
4335f30
Compare
mereghost
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applies the same pattern as done for the
ScheduleDateAlertsNotificationsJobin #15573 to theScheduleReminderMailsJob. It now also takes the time between the two cron_at values to be the boundaries in which the job operates.The similarities of the two jobs are now extracted into a shared module.
In order to avoid a single job being retried indefinitely a
retry_onlimit is added