Chore: avoid misleading "Unpermitted parameters: xxx" message log #15664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When `PermittedParams#settings` was called, it was not permitting any params, which lead to "Unpermitted parameters: ..." messages being logged, and then merged the resulting empty params with the controller params after having filtered them manually. It was ok-ish but the logged error message was misleading. The `#settings` method was refactored to permit params that are allowed in a single step and avoid the misleading log messages.
klaustopher
reviewed
May 27, 2024
`ActionController::Parameters#permit` takes a list of filters. There is no kwargs argument. Co-authored-by: Klaus Zanders <k.zanders@openproject.com>
"attachment_whitelist" is normally permitted as an array parameter, but the form passes it as a string parameter to be split. This commit adds a way to also permit parameters such as "attachment_whitelist" as a string parameter.
cbliard
force-pushed
the
fix/avoid_unpermitted_errors_logged
branch
from
84a4a9d to
b2f0a33
Compare
klaustopher
approved these changes
May 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
PermittedParams#settingswas called, it was not permitting any params, which lead to "Unpermitted parameters: ..." messages being logged, and then merged the resulting empty params with the controller params after having filtered them manually. It was ok-ish but the logged error message was misleading.The
#settingsmethod was refactored to permit params that are allowed in a single step and avoid the misleading log messages.The rubocop linting has been put in a separate commit for easier reviewing.