[chore] make flickering disappear #17212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- use test locale for localisation specs to avoid errors due to lazy i18n loading
apfohl
approved these changes
Nov 15, 2024
ulferts
reviewed
Nov 15, 2024
brunopagno
reviewed
Nov 15, 2024
Comment on lines
+86
to
+88
| after do | ||
| I18n.config.enforce_available_locales = true | ||
| end |
There was a problem hiding this comment.
Now that I see the comment above, this will also leak, no? Would it be better to store the original value and reassign it here, or is that overkill?
There was a problem hiding this comment.
Well, this is the original one. It is also the default. Not sure, if we should bother with variable assignment.
There was a problem hiding this comment.
It's all good, you get to make a call. My idea was to be a bit extra defensive. If we (or Rails) ever decides to make a change to this default 🙃 which is very unlikely.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
What approach did you choose and why?