Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make sure limit_self_registration is included in saml provider hash #17213

Merged
merged 2 commits into from
Nov 15, 2024
Merged

make sure limit_self_registration is included in saml provider hash #17213

merged 2 commits into from
Nov 15, 2024

Conversation

machisuji
Copy link
Member

WP #59375

@machisuji machisuji force-pushed the fix/missing-limit-self-registration-in-saml-provider-hash branch from aaed253 to f42fbc7 Compare November 15, 2024 15:00
toy
toy approved these changes Nov 15, 2024
View reviewed changes
Copy link
Contributor

@toy toy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks correct from my perspective, I only suggest a test that gets false in the hash when it is set so in the model

@machisuji machisuji merged commit ed0a8ce into release/15.0 Nov 15, 2024
11 checks passed
@machisuji machisuji deleted the fix/missing-limit-self-registration-in-saml-provider-hash branch November 15, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@toy toy toy approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@machisuji @toy