-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Start implementing mobile behavior for border-box table #17216
Conversation
7e51d62
to
a3e2a48
Compare
239c1d0
to
6832249
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks nice 👍 While clicking through, I found some issues:
- According to figma: On the meetings page, the project should not display a label in front on mobile
- On the meetings page, there are different vertical spacings between the elements. That happens on all places where an action button is displayed because the first row takes the height of that button. Thus is it is larger and the space appears bigger.
And one minor optional comment:
- Currently, I can enter empty values for the mobile_label and the mobile_columns which does not make much sense I guess. So maybe we should prevent that?
Do you have a suggestion on how to fix this? |
093b666
to
c4d1f23
Compare
c4d1f23
to
a613bc9
Compare
If you enter empty mobile_columns, it falls back to showing all columns - which I think is a good default |
Thanks for looking into it. It's definitely better than before 👍 |
* Start implementing mobile behavior for border-box table * Auto column * Allow labels * Hide rows on mobile * Change order of project and start time * Add implementation for oidc * Reimplement wide columns * Documentation * Remove custom mobile labels * Extract heading class * Fix spacing between rows in mobile BorderBoxTable * Remove doubled code block --------- Co-authored-by: Henriette Darge <h.darge@openproject.com>
Ticket
https://community.openproject.org/work_packages/59248
What are you trying to accomplish?
Trying to have all but the last column in the BorderBoxTableComponent stack on mobile