Code maintenance/59280 ensure that the new activity tab renders quickly also for work packages with over 100 comments #17224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rk packages with over 100 comments https://community.openproject.org/work_packages/59280
akabiru
requested changes
Nov 19, 2024
There was a problem hiding this comment.
Issue with scrolling on mobile - iOS Safari
https://community.openproject.org/api/v3/file_links/2093/open
akabiru
approved these changes
Nov 19, 2024
…further rendering optimizations
…he-new-activity-tab-renders-quickly-also-for-work-packages-with-over-100-comments
… will be fully cleaned up in other PR
…he-new-activity-tab-renders-quickly-also-for-work-packages-with-over-100-comments
Co-authored-by: Kabiru Mwenja <k.mwenja@openproject.com>
…be done in the feature flag removal PR
akabiru
approved these changes
Nov 21, 2024
Comment on lines
+82
to
+87
| journals.each do |journal| | ||
| journal.instance_variable_set( | ||
| :@unread_notifications, | ||
| notifications[journal.id] | ||
| ) | ||
| end |
| @@ -375,6 +375,7 @@ def rerender_journals_with_updated_notification(journals, last_update_timestamp, | |||
| # alternative approach in order to bypass the notification join issue in relation with the sequence_version query | |||
| Notification | |||
| .where(journal_id: journals.pluck(:id)) | |||
| .where(recipient_id: User.current.id) | |||
jjabari-op
deleted the
code-maintenance/59280-ensure-that-the-new-activity-tab-renders-quickly-also-for-work-packages-with-over-100-comments
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket