Rename LifeCycle to Project::LifeCycleStepDefinition and co #17248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t::StageDefinition and Gate to Project::GateDefinition
toy
reviewed
Nov 21, 2024
| @@ -1,5 +1,8 @@ | |||
| class AddLifeCycleToWorkPackages < ActiveRecord::Migration[7.1] | |||
| def change | |||
| add_reference :work_packages, :project_life_cycle, foreign_key: true, null: true | |||
| add_reference :work_packages, | |||
| :life_cycle_step, | |||
There was a problem hiding this comment.
I think project_ life_cycle_step should be more clear, though lengthier
If you change it foreign_key can be just true
| t.string :type | ||
| t.string :name | ||
| t.integer :position, default: 1, null: true |
There was a problem hiding this comment.
For ordering wherever they are listed?
| t.date :start_date | ||
| t.date :end_date | ||
| t.boolean :active, default: false, null: false | ||
| t.integer :position, default: 1, null: true |
There was a problem hiding this comment.
If this is for ordering when listing, then I think it should either follow the order of definitions or use start_date
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Part of https://community.openproject.org/wp/59287
What are you trying to accomplish?
Apply the class renamings discussed here: #17119 (comment) .
Merge checklist