Fix flaky cost_entries/add_cost_entry_spec.rb spec
#17714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Flaky spec was `./modules/costs/spec/features/cost_entries/add_cost_entry_spec.rb:114` It was failing for instance in https://github.com/opf/openproject/actions/runs/12934263465/job/36078482478 The flakiness is due to the js on the page not working until the spent_on date field is fully loaded. When the unit cost values are input, when the js is not working, then the computed "Costs" value is not updated, and so the test fails. The fix is simple: wait for the spent_on date field to be loaded with `page.has_field?(CostEntry.human_attribute_name(:spent_on))`. Then I refactored things a bit to remove some duplicate code and use some accessible selectors instead of css selectors.
klaustopher
approved these changes
Jan 24, 2025
cbliard
deleted the
fix-flaky/wait-for-log-unit-costs-page-to-be-fully-loaded
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flaky spec was
./modules/costs/spec/features/cost_entries/add_cost_entry_spec.rb:114It was failing for instance in https://github.com/opf/openproject/actions/runs/12934263465/job/36078482478The flakiness is due to the js on the page not working until the spent_on date field is fully loaded. When the unit cost values are input, when the js is not working, then the computed "Costs" value is not updated, and so the test fails.
The fix is simple: wait for the spent_on date field to be loaded with
page.has_field?(CostEntry.human_attribute_name(:spent_on)).Then I refactored things a bit to remove some duplicate code and use some accessible selectors instead of css selectors.
And disabled a cop which never made sense to me anyway.