[57090] Extract success/confirmation dialog content into common component #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 55bfcf7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
HDinger
force-pushed
the
code-maintenance/57090-extract-successconfirmation-dialog-content-into-common-component
branch
4 times, most recently
from
c6b0988 to
0b0ecef
Compare
HDinger
force-pushed
the
code-maintenance/57090-extract-successconfirmation-dialog-content-into-common-component
branch
5 times, most recently
from
e643417 to
278b3c3
Compare
HDinger
force-pushed
the
code-maintenance/57090-extract-successconfirmation-dialog-content-into-common-component
branch
2 times, most recently
from
e974d00 to
8c4ad29
Compare
…and add previews and tests
…kDialog" (which is harmonized with the FeedbackMessage it is using). Further, the inheritance was replaced by wrapping the component.
|
oliverguenther
approved these changes
Sep 3, 2024
Merged
judithroth
reviewed
Sep 3, 2024
| @dialog = Primer::Alpha::Dialog.new(title: @system_arguments[:title], subtitle: nil, visually_hide_title: true, **@system_arguments) | ||
| end | ||
|
|
||
| delegate :header?, :header, :with_header, :with_header_content, |
There was a problem hiding this comment.
👍 I like that you also did this as wrapper!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
https://community.openproject.org/projects/openproject/work_packages/57090/activity
What are you trying to accomplish?
FeedbackMessagecomponentBlankslateinternatllyFeedbackDialogcomponentFeedbackMessageclosebutton, but additional ones can be added