Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added connect and disconnect RPC #41

Merged
merged 1 commit into from
Nov 10, 2022
Merged

Conversation

harishp8889
Copy link
Contributor

Added the below RPCs:

  1. NVMeControllerConnect
  2. NVMeControllerDisconnect

@harishp8889 harishp8889 requested a review from a team as a code owner November 9, 2022 14:37
@harishp8889 harishp8889 force-pushed the feature/dpu branch 3 times, most recently from ccc475a to 65f8f0d Compare November 9, 2022 15:29
Copy link
Member

@glimchb glimchb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, but tests failed, please fix

goopicsi_test.go Outdated Show resolved Hide resolved
Signed-off-by: Harish P <harish_p4@dell.com>
@codecov
Copy link

codecov bot commented Nov 10, 2022

Codecov Report

Merging #41 (896989f) into main (d1670e9) will increase coverage by 28.09%.
The diff coverage is 47.22%.

❗ Current head 896989f differs from pull request most recent head 74c2287. Consider uploading reports for the commit 74c2287 to get more accurate results

@@            Coverage Diff             @@
##            main      #41       +/-   ##
==========================================
+ Coverage   0.00%   28.09%   +28.09%     
==========================================
  Files          1        1               
  Lines         49      121       +72     
==========================================
+ Hits           0       34       +34     
- Misses        49       84       +35     
- Partials       0        3        +3     
Impacted Files Coverage Δ
goopicsi.go 28.09% <47.22%> (+28.09%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@glimchb glimchb merged commit 056d986 into opiproject:main Nov 10, 2022
@harishp8889 harishp8889 deleted the feature/dpu branch November 10, 2022 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants