Added Get and List RPC #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #49 +/- ##
==========================================
+ Coverage 24.81% 31.57% +6.76%
==========================================
Files 1 1
Lines 137 171 +34
==========================================
+ Hits 34 54 +20
- Misses 100 112 +12
- Partials 3 5 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
harshitap26
force-pushed
the
feature/NVMf_rpc
branch
from
1e81512 to
cf4ca22
Compare
harishp8889
suggested changes
Nov 14, 2022
goopicsi.go
Outdated
| @@ -126,6 +126,50 @@ func NVMeControllerConnect(request *pb.NVMfRemoteController) (*pb.NVMfRemoteCont | |||
| return &pb.NVMfRemoteControllerConnectResponse{}, nil | |||
| } | |||
|
|
|||
| // NVMeControllerList lists all the connections to the remote NVMf controller | |||
| func NVMeControllerList() (*pb.NVMfRemoteControllerListResponse, error) { | |||
There was a problem hiding this comment.
Please change this to some other struct instead of returning the proto messages
goopicsi.go
Outdated
| } | ||
|
|
||
| // NVMeControllerGet lists the connection to the remote NVMf controller corresponding to the given ID | ||
| func NVMeControllerGet(request *pb.NVMfRemoteControllerGetRequest) (*pb.NVMfRemoteControllerGetResponse, error) { |
There was a problem hiding this comment.
Here as well, Avoid using the proto messages directly on the request and response objects.
Added Get and List RPC Signed-off-by: harshita Pandey <harshita_pandey@dell.com> Removing proto messages Signed-off-by: harshita Pandey <harshita_pandey@dell.com>
harshitap26
force-pushed
the
feature/NVMf_rpc
branch
from
c9eba76 to
fa5bbec
Compare
harishp8889
approved these changes
Nov 14, 2022
glimchb
approved these changes
Nov 14, 2022
glimchb
reviewed
Nov 14, 2022
| return err | ||
| } | ||
| log.Printf("Connection corresponding to the given ID: %v", response) | ||
| return nil |
There was a problem hiding this comment.
should you return some data here ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the below RPCs:
NVMfRemoteControllerGet
NVMfRemoteControllerList