Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mocks and test addition #60

Closed
wants to merge 4 commits into from
Closed

Conversation

gilltaran
Copy link

mocks and testcase addition.

@gilltaran gilltaran requested a review from a team as a code owner November 28, 2022 13:19
@codecov
Copy link

codecov bot commented Nov 28, 2022

Codecov Report

Merging #60 (8126498) into main (4cbffef) will decrease coverage by 2.19%.
The diff coverage is 87.50%.

❗ Current head 8126498 differs from pull request most recent head cae3c94. Consider uploading reports for the commit cae3c94 to get more accurate results

@@            Coverage Diff             @@
##             main      #60      +/-   ##
==========================================
- Coverage   37.21%   35.01%   -2.20%     
==========================================
  Files           1        1              
  Lines         309      297      -12     
==========================================
- Hits          115      104      -11     
+ Misses        186      185       -1     
  Partials        8        8              
Impacted Files Coverage Δ
goopicsi.go 35.01% <87.50%> (-2.20%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@glimchb glimchb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please fix linters @gilltaran

Signed-off-by: taran <Tarandeep.S@dell.com>

formetting checks resolved

Signed-off-by: taran <Tarandeep.S@dell.com>

mocks addition

Signed-off-by: taran <Tarandeep.S@dell.com>

correction for checks failure

Signed-off-by: taran <Tarandeep.S@dell.com>
gilltaran and others added 3 commits December 13, 2022 18:50
Signed-off-by: gilltaran <91598969+gilltaran@users.noreply.github.com>
Signed-off-by: taran <Tarandeep.S@dell.com>
Signed-off-by: taran <Tarandeep.S@dell.com>
@glimchb
Copy link
Member

glimchb commented Dec 15, 2022

see #71 instead

@glimchb glimchb closed this Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants