Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comment for NVMeSubsystem #90

Merged
merged 2 commits into from
Jan 13, 2023
Merged

Conversation

harshitap26
Copy link
Contributor

Signed-off-by: Harshita Pandey Harshita_Pandey@dell.com

Signed-off-by: Harshita Pandey <Harshita_Pandey@dell.com>
@harshitap26 harshitap26 requested a review from a team as a code owner January 13, 2023 14:29
@codecov
Copy link

codecov bot commented Jan 13, 2023

Codecov Report

Merging #90 (82ff797) into main (f17003d) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #90   +/-   ##
=======================================
  Coverage   43.03%   43.03%           
=======================================
  Files           1        1           
  Lines         244      244           
=======================================
  Hits          105      105           
  Misses        123      123           
  Partials       16       16           
Impacted Files Coverage Δ
goopicsi.go 43.03% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@glimchb glimchb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we also add the same comment on line 163
because this is what customer of this function would see...

Signed-off-by: Harshita Pandey <Harshita_Pandey@dell.com>
@harshitap26
Copy link
Contributor Author

can we also add the same comment on line 163 because this is what customer of this function would see...

Added the comment.

@glimchb glimchb merged commit da55619 into opiproject:main Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants