Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add grpc gw http listener #182

Merged
merged 2 commits into from
Sep 13, 2023
Merged

feat: add grpc gw http listener #182

merged 2 commits into from
Sep 13, 2023

Conversation

glimchb
Copy link
Member

@glimchb glimchb commented Sep 13, 2023

this is using inventory service as an example
once we fix opi-api compiler we can remove inventory
and replace it with network gw registration

Signed-off-by: Boris Glimcher Boris.Glimcher@emc.com

@glimchb glimchb linked an issue Sep 13, 2023 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Sep 13, 2023

Codecov Report

Merging #182 (2828037) into main (c1f0da9) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #182   +/-   ##
=======================================
  Coverage   75.00%   75.00%           
=======================================
  Files           5        5           
  Lines        1012     1012           
=======================================
  Hits          759      759           
  Misses        218      218           
  Partials       35       35           

this is needed to show grpc-gateway work

Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>
this is using inventory service as an example
once we fix opi-api compiler we can remove inventory
and replace it with network gw registration

Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>
@glimchb glimchb marked this pull request as ready for review September 13, 2023 19:25
@glimchb glimchb requested a review from a team as a code owner September 13, 2023 19:25
@glimchb glimchb added the Merge Candidate in the open merge window, next candidate for merge label Sep 13, 2023
@glimchb glimchb merged commit 2b3f8c6 into opiproject:main Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Merge Candidate in the open merge window, next candidate for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add grpc gw http listener
1 participant