Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(common): move inventory to separate folder #232

Merged
merged 4 commits into from
Oct 16, 2023

Conversation

sandersms
Copy link
Contributor

@sandersms sandersms commented Oct 12, 2023

Moving inventory from common to separate folder to allow for future additions such as capabilities protobuf and to support the autogeneration of protobuf files using 'buf'

blocked by opiproject/opi-api#386
blocked by opiproject/opi-smbios-bridge#208

sandersms and others added 3 commits October 12, 2023 17:01
Signed-off-by: Mark Sanders <marksanders194@gmail.com>
Signed-off-by: Mark Sanders <marksanders194@gmail.com>
@sandersms sandersms marked this pull request as ready for review October 16, 2023 19:51
@sandersms sandersms requested a review from a team as a code owner October 16, 2023 19:51
Signed-off-by: Mark Sanders <marksanders194@gmail.com>
@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

Merging #232 (0cac58b) into main (158ad22) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #232   +/-   ##
=======================================
  Coverage   64.84%   64.84%           
=======================================
  Files          16       16           
  Lines        1317     1317           
=======================================
  Hits          854      854           
  Misses        426      426           
  Partials       37       37           

Copy link
Member

@glimchb glimchb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sandersms sandersms merged commit 5d1f231 into opiproject:main Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants