Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move proto to utils #275

Merged
merged 1 commit into from
Oct 19, 2023
Merged

refactor: move proto to utils #275

merged 1 commit into from
Oct 19, 2023

Conversation

glimchb
Copy link
Member

@glimchb glimchb commented Oct 19, 2023

Signed-off-by: Boris Glimcher Boris.Glimcher@emc.com

Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>
@codecov
Copy link

codecov bot commented Oct 19, 2023

Codecov Report

Merging #275 (a42a1a0) into main (37a83fb) will increase coverage by 0.01%.
The diff coverage is 21.05%.

@@            Coverage Diff             @@
##             main     #275      +/-   ##
==========================================
+ Coverage   61.48%   61.49%   +0.01%     
==========================================
  Files          28       29       +1     
  Lines        1851     1818      -33     
==========================================
- Hits         1138     1118      -20     
+ Misses        609      604       -5     
+ Partials      104       96       -8     
Files Coverage Δ
pkg/bridge/common.go 82.35% <ø> (+6.54%) ⬆️
pkg/port/common.go 82.35% <ø> (+6.54%) ⬆️
pkg/svi/common.go 82.35% <ø> (+6.54%) ⬆️
pkg/vrf/common.go 79.66% <ø> (+5.37%) ⬆️
pkg/bridge/grpc.go 56.95% <50.00%> (ø)
pkg/port/grpc.go 57.71% <50.00%> (ø)
pkg/svi/grpc.go 48.86% <50.00%> (ø)
pkg/vrf/grpc.go 55.48% <50.00%> (ø)
pkg/utils/proto.go 0.00% <0.00%> (ø)

@glimchb glimchb marked this pull request as ready for review October 19, 2023 21:38
@glimchb glimchb requested a review from a team as a code owner October 19, 2023 21:38
@glimchb glimchb merged commit 7d9158d into opiproject:main Oct 19, 2023
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant