Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactoring: code dup reduction in tests #292

Merged
merged 1 commit into from
Oct 24, 2023
Merged

Conversation

glimchb
Copy link
Member

@glimchb glimchb commented Oct 24, 2023

Signed-off-by: Boris Glimcher Boris.Glimcher@emc.com

@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

Merging #292 (f7aa1eb) into main (02cf2ee) will increase coverage by 0.52%.
The diff coverage is 70.00%.

@@            Coverage Diff             @@
##             main     #292      +/-   ##
==========================================
+ Coverage   58.18%   58.71%   +0.52%     
==========================================
  Files          30       30              
  Lines        1722     1802      +80     
==========================================
+ Hits         1002     1058      +56     
- Misses        632      648      +16     
- Partials       88       96       +8     
Files Coverage Δ
pkg/bridge/common.go 69.23% <70.00%> (+0.80%) ⬆️
pkg/port/common.go 69.23% <70.00%> (+0.80%) ⬆️
pkg/svi/common.go 69.23% <70.00%> (+0.80%) ⬆️
pkg/vrf/common.go 68.08% <70.00%> (+1.41%) ⬆️

Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>
@glimchb glimchb marked this pull request as ready for review October 24, 2023 21:27
@glimchb glimchb requested a review from a team as a code owner October 24, 2023 21:27
@glimchb glimchb added the Merge Candidate in the open merge window, next candidate for merge label Oct 24, 2023
@glimchb glimchb merged commit ae6a0dc into opiproject:main Oct 24, 2023
@glimchb glimchb deleted the models branch October 24, 2023 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Merge Candidate in the open merge window, next candidate for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant