fix(evpn-bridge): update for api dependencies on evpn-gw api #369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mark Sanders <marksanders194@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #369 +/- ##
=======================================
Coverage 58.92% 58.92%
=======================================
Files 30 30
Lines 1816 1816
=======================================
Hits 1070 1070
Misses 650 650
Partials 96 96 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Mark Sanders <marksanders194@gmail.com>
There was a problem hiding this comment.
Should we also update ptype of this exemplary command in README?
Signed-off-by: Mark Sanders <marksanders194@gmail.com>
Nice catch - I missed that one and put the change in to have that covers. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes to enum updates in evpn gw api