Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Experiment refactoring #404

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from
Draft

Experiment refactoring #404

wants to merge 10 commits into from

Conversation

mardim91
Copy link
Contributor

@mardim91 mardim91 commented Oct 9, 2024

No description provided.

@mardim91
feat(evpn-bridge): introduce replaydb feature
9c31a9f 
Signed-off-by: Dimitrios Markou <dimitrios.markou@ericsson.com>
@mardim91
fix(evpn): fix lint errors first attempt
18ad617 
Signed-off-by: Dimitrios Markou <dimitrios.markou@ericsson.com>
@mardim91
fix(evpn): use deferErr to assign the returned error
3154210 
Signed-off-by: Dimitrios Markou <dimitrios.markou@ericsson.com>
@mardim91
fix(evpn): create checkStatus func in task manager
71c21eb 
Signed-off-by: Dimitrios Markou <dimitrios.markou@ericsson.com>
@mardim91
fix(evpn): rename infradb utils file
8e1acef 
Signed-off-by: Dimitrios Markou <dimitrios.markou@ericsson.com>
@mardim91
fix(evpn): remove comments
763cb1f 
Signed-off-by: Dimitrios Markou <dimitrios.markou@ericsson.com>
@mardim91
fix(evpn): replace loops with a map
68d99a3 
Signed-off-by: Dimitrios Markou <dimitrios.markou@ericsson.com>
@mardim91
fix(evpn): addressing reviews first attempt
0b19561 
Signed-off-by: Dimitrios Markou <dimitrios.markou@ericsson.com>
@mardim91
fix(evpn): addressing reviews second attempt
5c16199 
Signed-off-by: Dimitrios Markou <dimitrios.markou@ericsson.com>
@mardim91
fix(evpn): move to template design method approach
73dae37 
Signed-off-by: Dimitrios Markou <dimitrios.markou@ericsson.com>
@mardim91 mardim91 requested a review from a team as a code owner October 9, 2024 14:22
sandersms
sandersms approved these changes Jan 21, 2025
View reviewed changes
Copy link
Contributor

@sandersms sandersms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mardim91 mardim91 marked this pull request as draft January 22, 2025 09:13
@mardim91
Copy link
Contributor Author

[DO NOT MERGE] This PR is used only for refactoring experiments currently,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sandersms sandersms sandersms approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mardim91 @sandersms