Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix code after API changes #18

Merged
merged 1 commit into from
Nov 1, 2022
Merged

fix code after API changes #18

merged 1 commit into from
Nov 1, 2022

Conversation

glimchb
Copy link
Member

@glimchb glimchb commented Oct 31, 2022

see opiproject/opi-api#179

Signed-off-by: Boris Glimcher Boris.Glimcher@emc.com

@glimchb glimchb self-assigned this Oct 31, 2022
@glimchb glimchb marked this pull request as ready for review November 1, 2022 22:59
@glimchb glimchb requested a review from a team as a code owner November 1, 2022 22:59
@glimchb glimchb requested review from jainvipin and PWAlessi November 1, 2022 23:04
@glimchb glimchb force-pushed the objectid branch 3 times, most recently from b5b1bd7 to d19c190 Compare November 1, 2022 23:17
see opiproject/opi-api#179

Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>
Copy link
Contributor

@jainvipin jainvipin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - looks much cleaner!

@glimchb glimchb merged commit 780c9eb into opiproject:main Nov 1, 2022
Copy link

@PWAlessi PWAlessi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@@ -9,14 +9,15 @@ import (
"log"

pb "github.com/opiproject/opi-api/storage/v1/gen/go"
"github.com/ulule/deepcopier"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good find. I've never used deepcopier before.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants