Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: tests for daemon and run command #454

Merged
merged 2 commits into from
Jan 21, 2025
Merged

feat: tests for daemon and run command #454

merged 2 commits into from
Jan 21, 2025

Conversation

bhoopesh369
Copy link
Contributor

Proposed changes

closes #425

Types of changes

  • New feature (non-breaking change which adds functionality)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices applies)

Checklist

  • I have signed the commit for DCO to be passed.
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added necessary documentation (if appropriate)

@bhoopesh369
feat: tests for daemon and run
e946cff 
Signed-off-by: Bhoopesh <bhoopesh459@gmail.com>
@bhoopesh369
fix: tests for daemon and run command
8a38e22 
Signed-off-by: Bhoopesh <bhoopesh459@gmail.com>
@bhoopesh369 bhoopesh369 requested a review from a team as a code owner November 4, 2024 15:28
@bhoopesh369
Copy link
Contributor Author

@glimchb please review this pr

sandersms
sandersms approved these changes Jan 21, 2025
View reviewed changes
Copy link

@sandersms sandersms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look reasonable.

@sandersms sandersms merged commit 527e05a into opiproject:main Jan 21, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sandersms sandersms sandersms approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

tests for daemon and run command
2 participants
@bhoopesh369 @sandersms