Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Menu event doesn't fire on the new release. #64

Closed
Morichalion opened this issue Jun 5, 2021 · 2 comments
Closed

Menu event doesn't fire on the new release. #64

Morichalion opened this issue Jun 5, 2021 · 2 comments
Labels
bug Something isn't working

Comments

@Morichalion
Copy link

Current behavior

Menu event doesn't fire.

Expected behavior

Menu even should fire when leaving game to go to a menu.

Reproduction steps

  1. Finish song or fail song.
  2. See behavior reliant on menu event not work.

Solution

  1. Change overlay to use "finished" or "failed" events.

BeatSaber version: 1.16.1
HTTP Status version: 1.16.1
Platform: Index. LIV.
@Morichalion
Copy link
Author

To be clear, this just strikes me as a documentation issue. The menu event isn't really needed

@opl- opl- added the bug Something isn't working label Jun 5, 2021
@opl-
Copy link
Owner

opl- commented Jun 5, 2021

Fixed in 23cdee6

@opl- opl- closed this as completed Jun 5, 2021
opl- added a commit that referenced this issue Jun 5, 2021
@opl-
Release v1.16.1
f07ff19 
Fixes:
- `menu` event not fired (#64)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@opl- @Morichalion