Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.18 Cover image for non-custom songs displays all cover images in one #82

Closed
peddermaster2 opened this issue Nov 19, 2021 · 2 comments
Closed
Labels
bug Something isn't working

Comments

@peddermaster2
Copy link

peddermaster2 commented Nov 19, 2021

Current behavior

Playing a Beat Saber / non-custom Song the cover image is huge image with all cover images.
grafik
grafik

Expected behavior

Only the cover image of the currently played song is displayed.

Reproduction steps

Play any non-custom Beat Saber song.

Environment

BeatSaber version: 1.18.3
HTTP Status version: 1.19.1 bs1.18.0 c7d6ab6
Platform: Steam, Valve Index

@opl-
Copy link
Owner

opl- commented Jan 4, 2022

Finally looked into this. It looks like the texture rectangle isn't exposed by Unity in the Sprite instance we get from Beat Saber's GetCoverImageAsync, so it's either stored somewhere by the game itself and I failed to notice it, or I'm just unable to access it through the Sprite getters for whatever reason. I'll give it another shot when I'm more awake.

@opl- opl- added the bug Something isn't working label Jan 4, 2022
@opl- opl- closed this as completed in 2899e5c Jan 5, 2022
@opl-
Copy link
Owner

opl- commented Jan 5, 2022

After more investigation and some encouragement from Auros, I found out that Sprite.uv returns useful values which I missed because they were being rounded by the stringification when logging. For whatever reason Sprite.textureRect and Sprite.rect don't return valid values for the sprite position in the atlas.

opl- added a commit that referenced this issue Jan 5, 2022
Adds:
- `beatmap.characteristic` (#84)

Fixes:
- Entire texture atlas sent as cover for vanilla beatmaps (#82)

Changes:
- Updated protocol documentation to mention new beatmap characteristics
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants