Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mvc/view: Create layout_partials/base_apply_button to centralize design of the standard Apply button #8297

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

mvc/view: Create layout_partials/base_apply_button to centralize design of the standard Apply button #8297

wants to merge 3 commits into from
+29 −21

Conversation

Monviech
Copy link
Member

@Monviech Monviech commented Feb 7, 2025 •
edited
Loading

Fixes: #8284

Example of generated HTML with the KEA example implementation:

<section class="page-content-main">
    <div class="content-box">
        <div class="col-md-12">
            <br>
            <div id="change_message_base_form" class="alert alert-info" style="display: none;" role="alert">
                After changing settings, please remember to apply them.            </div>
            <button class="btn btn-primary" id="reconfigureAct" data-endpoint="/api/kea/service/reconfigure" data-label="Apply" data-error-title="Error reconfiguring service." type="button"><b>Apply</b> <i class="reload_progress"></i></button>
            <br><br>
        </div>
    </div>
</section>

AdSchellevis
AdSchellevis requested changes Feb 7, 2025
View reviewed changes
Copy link
Member

@AdSchellevis AdSchellevis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this will further simplify our templates, which is good, but I do have some concerns which I've added in the comments.

src/opnsense/mvc/app/views/OPNsense/Kea/dhcpv4.volt Outdated Show resolved Hide resolved
src/opnsense/mvc/app/views/layout_partials/base_apply_button.volt Outdated Show resolved Hide resolved
src/opnsense/mvc/app/views/layout_partials/base_apply_button.volt Show resolved Hide resolved
src/opnsense/mvc/app/views/layout_partials/base_apply_button.volt Show resolved Hide resolved
src/opnsense/mvc/app/controllers/OPNsense/Kea/DhcpController.php Show resolved Hide resolved
@Monviech
mvc/view: Change edit_alert_id to global static default, add data-gri…
c5c5b4a 
…d-reload and dynamic ids to base_apply_button partial
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fichtner fichtner fichtner approved these changes

@AdSchellevis AdSchellevis Awaiting requested review from AdSchellevis

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

mvc/view: Replace Apply button with template?
3 participants
@Monviech @fichtner @AdSchellevis