Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mvc/view: Create layout_partials/base_apply_button to centralize design of the standard Apply button #8297

Merged
merged 3 commits into from
Feb 10, 2025

Conversation

Monviech
Copy link
Member

@Monviech Monviech commented Feb 7, 2025

Fixes: #8284

Example of generated HTML with the KEA example implementation:

<section class="page-content-main">
    <div class="content-box">
        <div class="col-md-12">
            <br>
            <div id="change_message_base_form" class="alert alert-info" style="display: none;" role="alert">
                After changing settings, please remember to apply them.            </div>
            <button class="btn btn-primary" id="reconfigureAct" data-endpoint="/api/kea/service/reconfigure" data-label="Apply" data-error-title="Error reconfiguring service." type="button"><b>Apply</b> <i class="reload_progress"></i></button>
            <br><br>
        </div>
    </div>
</section>

Copy link
Member

@AdSchellevis AdSchellevis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this will further simplify our templates, which is good, but I do have some concerns which I've added in the comments.

…d-reload and dynamic ids to base_apply_button partial
@Monviech Monviech merged commit 24a6142 into master Feb 10, 2025
@Monviech Monviech deleted the fr8284_button branch February 10, 2025 15:57
@Monviech
Copy link
Member Author

Merged as discussed with @AdSchellevis

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

mvc/view: Replace Apply button with template?
3 participants