Skip to content

Commit

Permalink
Update to react-scripts v5
Browse files Browse the repository at this point in the history
The e2e test were failing with react-scripts v5. setimmediate is added to
fix these.

Signed-off-by: Benedikt Richter <benedikt.richter@tngtech.com>
  • Loading branch information
benedikt-richter committed Dec 15, 2021
1 parent 9e85ff4 commit 59d7167
Show file tree
Hide file tree
Showing 3 changed files with 3,115 additions and 5,949 deletions.
3 changes: 2 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -68,9 +68,10 @@
"nunjucks": "^3.2.3",
"playwright": "^1.17.1",
"prettier": "^2.5.1",
"react-scripts": "4.0.3",
"react-scripts": "5.0.0",
"redux-devtools-extension": "^2.13.9",
"run-script-os": "^1.1.6",
"setimmediate": "^1.0.5",
"typescript": "^4.5.4",
"wait-on": "^6.0.0"
},
Expand Down
1 change: 1 addition & 0 deletions src/e2e-tests/test-helpers/test-helpers.ts
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ export async function getApp(
): Promise<ElectronApplication> {
const app = 'build/ElectronBackend/app.js';

require('setimmediate'); // required to work with react-scripts v5
return await _electron.launch({
args: commandLineArg ? [app, commandLineArg] : [app],
timeout: ELECTRON_LAUNCH_TEST_TIMEOUT,
Expand Down
Loading

0 comments on commit 59d7167

Please sign in to comment.