feat: use nivo responsive bar chart for progress and criticality bar #2639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meretp
force-pushed
the
feat/improve-progress-bar
branch
3 times, most recently
from
2b8093a to
263b82b
Compare
meretp
force-pushed
the
feat/improve-progress-bar
branch
5 times, most recently
from
bd0f00b to
70a2cdb
Compare
meretp
commented
Jun 24, 2024
src/Frontend/Components/ProgressBar/__tests__/ProgressBar.test.tsx
Outdated
Show resolved
Hide resolved
mstykow
force-pushed
the
feat/improve-progress-bar
branch
from
70a2cdb to
52bb95c
Compare
mstykow
requested changes
Aug 25, 2024
| margin: 2, | ||
| fontWeight: 500, | ||
| position: 'relative', | ||
| top: 100, |
There was a problem hiding this comment.
the positioning is not working consistently: depending on the bar's mode, the tooltip appears higher or lower below the cursor. could you find a way to make the positioning consistent?
There was a problem hiding this comment.
This is still to do, but so far I couldn't find a way.
meretp
force-pushed
the
feat/improve-progress-bar
branch
from
a9f8281 to
48494e3
Compare
meretp
force-pushed
the
feat/improve-progress-bar
branch
2 times, most recently
from
3cd1ce4 to
f5db9c1
Compare
mstykow
reviewed
Sep 22, 2024
| margin: 2, | ||
| fontWeight: 500, | ||
| position: 'relative', | ||
| top: 100, |
meretp
force-pushed
the
feat/improve-progress-bar
branch
from
f5db9c1 to
793d773
Compare
mstykow
force-pushed
the
feat/improve-progress-bar
branch
from
793d773 to
8932d9c
Compare
mstykow
force-pushed
the
feat/improve-progress-bar
branch
2 times, most recently
from
8dd902a to
b4fece8
Compare
|
The following issues need to be solved before this PR can merge:
|
meretp
force-pushed
the
feat/improve-progress-bar
branch
from
b4fece8 to
a17f08b
Compare
|
Added some commits that fixes the second issue and updates nivo bar - there has been a new release in the meantime. Also I updated the diff to use the ariaLabel from ResponsiveBar. |
Signed-off-by: Meret Behrens <meret.behrens@tngtech.com> Signed-off-by: Maxim Stykow <maxim.stykow@tngtech.com>
Signed-off-by: Meret Behrens <meret.behrens@tngtech.com>
There are still some issues: 1. the position differs between tooltip modes 2. when resizing the window down, the new bar chart does not resize itself thus causing x-overflow Signed-off-by: Maxim Stykow <maxim.stykow@tngtech.com>
meretp
force-pushed
the
feat/improve-progress-bar
branch
from
a17f08b to
8df5617
Compare
|
To fix the first issue the only idea I could come up with is to use sepearate CSS styling like to transform the tooltips separately. This does not feel like a stable solution so I only add this as a comment not commit yet, what do you think? |
|
Have to take a look at why the unit tests are failing now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
To improve the progress bar this PR adds a new library nivo and introduces a ResponsiveBar.
Context and reason for change
fixes part of #2622
How can the changes be tested
Open OpossumUI and play around with the progress/criticality bar.
Note: Please review the guidelines for contributing to this repository.