Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unselect All option in Developer Options not working #4186

Closed
anandwana001 opened this issue Feb 14, 2022 · 9 comments · Fixed by #4383
Closed

Unselect All option in Developer Options not working #4186

anandwana001 opened this issue Feb 14, 2022 · 9 comments · Fixed by #4383
Assignees
@KevinGitonga
Labels
good first issue This item is good for new contributors to make their pull request. Impact: Low Low perceived user impact (e.g. edge cases). Z-ibt Temporary label for Ben to keep track of issues he's triaged.

Comments

@anandwana001
Copy link
Contributor

anandwana001 commented Feb 14, 2022 •
edited by rt4914
Loading

Describe the bug
The Developer options have three items, Mark Chapters, Mart Stories, and Mark Topic. Inside each item, there is an option to select all at once.
But, unselecting the all option didn't work correctly.

To Reproduce
Steps to reproduce the behavior:

  1. Go to admin profile
  2. Swipe left from the Home screen and click on Developer options
  3. Open any item of the three-item (Mark Chapters, Mart Stories, and Mark Topic) and select all
  4. Click all again and it will not unselect

Expected behavior
It should unselect all items correctly.

Demonstration
Screenshot_20220214_163035

Environment

  • Device/emulator being used: emulator
  • Android or SDK version (e.g. Android 5 or SDK 21): SDK 30
  • App version (you can get this through system app settings or via the admin controls menu in-app): 1.0

Additional context
In PR please add test case showing that this has been fixed now.
@anandwana001
Copy link
Contributor Author

@rt4914 If you have any thoughts on this or any context I am missing.

@rt4914
Copy link
Contributor

rt4914 commented Feb 14, 2022

@anandwana001 No. This is a bug as per explanation. Shifting it to good-first-issue.

@rt4914 rt4914 added the good first issue This item is good for new contributors to make their pull request. label Feb 14, 2022
@Akshatkamboj14
Copy link
Member

can you assign me this?

@rishidyno
Copy link
Contributor

@Akshatkamboj14 Unassigning you due to inactivity. If you are working on this, please reassign yourself.

@shankarpriyank
Copy link
Contributor

I would like to work on this @bkaur-bkj

@visheshkadian
Copy link

@anandwana001 @rt4914 I would like to work on this bug can you assign me this

visheshkadian added a commit to visheshkadian/oppia-android that referenced this issue Mar 12, 2022
@visheshkadian
fix of CheckBox to unselect CheckBox oppia#4186
be44ec2
@visheshkadian visheshkadian mentioned this issue Mar 12, 2022
Closed
6 tasks
@visheshkadian
Copy link

@anandwana001 @rt4914 Hey! I have fixed the issue, can you review my PR??

visheshkadian added a commit to visheshkadian/oppia-android that referenced this issue Mar 19, 2022
@visheshkadian
fix of oppia#4186 and ktlint
ac8245e
@visheshkadian
Copy link

@anandwana001 sir, I wanted to ask you that since I made a PR for this issue which only solves the issue for Mark Topic Completed but the same issue is there for Mark Chapters and Mark Stories so should I make a new PR for both of them or push it in the same PR?

KevinGitonga added a commit to KevinGitonga/oppia-android that referenced this issue Jun 7, 2022
@KevinGitonga
Fix oppia#4186 Uncheck all selection on developer options not working
0cff83a
@KevinGitonga KevinGitonga mentioned this issue Jun 8, 2022
Merged
6 tasks
KevinGitonga added a commit to KevinGitonga/oppia-android that referenced this issue Jun 8, 2022
@KevinGitonga
Fix oppia#4186 Add changes to code as suggested on code review.
5295364
KevinGitonga added a commit to KevinGitonga/oppia-android that referenced this issue Jun 9, 2022
@KevinGitonga
Fix oppia#4186 Undo changes on line wrap as advised by code reviewer.
ca5bca5
@Broppia Broppia added issue_type_bug Impact: Low Low perceived user impact (e.g. edge cases). labels Jun 13, 2022
KevinGitonga added a commit to KevinGitonga/oppia-android that referenced this issue Jun 14, 2022
@KevinGitonga
Revert "Fix oppia#4186 Undo changes on line wrap as advised by code r…
3e99863 
…eviewer."

This reverts commit ca5bca5.
KevinGitonga added a commit to KevinGitonga/oppia-android that referenced this issue Jun 14, 2022
@KevinGitonga
Revert "Fix oppia#4186 Add changes to code as suggested on code review."
4a60eac 
This reverts commit 5295364.
KevinGitonga added a commit to KevinGitonga/oppia-android that referenced this issue Jun 14, 2022
@KevinGitonga
Revert "Fix oppia#4186 Uncheck all selection on developer options not…
94222cf 
… working"

This reverts commit 0cff83a.
KevinGitonga added a commit to KevinGitonga/oppia-android that referenced this issue Jul 6, 2022
@KevinGitonga
Add tests for oppia#4186.
8882088
KevinGitonga added a commit to KevinGitonga/oppia-android that referenced this issue Jul 6, 2022
@KevinGitonga
Add tests for oppia#4186, Undo changes on build.gradle.
13ce51c
@BenHenning BenHenning added Z-ibt Temporary label for Ben to keep track of issues he's triaged. issue_user_developer labels Sep 15, 2022
@BenHenning BenHenning reopened this Oct 6, 2022
@BenHenning
Copy link
Member

This shouldn't have been closed earlier.

BenHenning added a commit that referenced this issue Oct 10, 2022
@KevinGitonga @BenHenning
Fix #4186: Uncheck all selection on developer options not working (#4383
d1f5309 
)

* Fix #4186 Uncheck all selection on developer options not working

* Fix #4186 Add changes to code as suggested on code review.

* Fix #4186 Undo changes on line wrap as advised by code reviewer.

* Add tests for #4186.

* Add tests for #4186, Undo changes on build.gradle.

* Update and makes changes as advised by code reviewer.

* Update test names to deselect from unselect.

* Fix broken tests after update.

* Move the 'scrollToPosition' call inside of 'verifyItemCheckedOnRecyclerViewItemAtPosition', to reduce boilerplate code.

* Add changes to run tests directly by removing unnecessary verification on initial click #2658.

* Updates tests and fix missed issues supposed to be updated.

* Update tests to assert if Checkbox is actually Unchecked after unchecking.

* Add testCoroutinesDispatchers.runCurrent() line to avoid MarkChaptersCompletedFragmentTest.kt deselectsAllChapters test from failing.

* Fix lint failing test, after update.

* Fix broken view models.

Co-authored-by: Ben Henning <ben@oppia.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KevinGitonga KevinGitonga

Labels
good first issue This item is good for new contributors to make their pull request. Impact: Low Low perceived user impact (e.g. edge cases). Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
[Team] Developer Workflow & Infrastructure - Android
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #4186: Uncheck all selection on developer options not working KevinGitonga/oppia-android
9 participants
@rt4914 @BenHenning @KevinGitonga @anandwana001 @visheshkadian @shankarpriyank @rishidyno @Akshatkamboj14 @Broppia