Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CI checks to ensure layout xml files are only referencing colors from component_colors.xml #4396

Closed
ayush0402 opened this issue Jun 19, 2022 · 2 comments · Fixed by #4882
Closed

Add CI checks to ensure layout xml files are only referencing colors from component_colors.xml #4396

ayush0402 opened this issue Jun 19, 2022 · 2 comments · Fixed by #4882
Assignees
@MohitGupta121
Labels
enhancement End user-perceivable enhancements. Impact: Low Low perceived user impact (e.g. edge cases). Issue: Needs Clarification Indicates that an issue needs more detail in order to be able to be acted upon. Z-ibt Temporary label for Ben to keep track of issues he's triaged.

Comments

@ayush0402
Copy link
Contributor

According to newer color conventions, all layout files should only access colors from component_colors.xml.
Add a CI check ensuring the same.

Reference: #4203, #4205
@ayush0402 ayush0402 mentioned this issue Jun 19, 2022
Merged
13 tasks
@Broppia Broppia added issue_type_infrastructure Impact: Low Low perceived user impact (e.g. edge cases). labels Jul 7, 2022
@BenHenning BenHenning added Issue: Needs Clarification Indicates that an issue needs more detail in order to be able to be acted upon. Z-ibt Temporary label for Ben to keep track of issues he's triaged. issue_user_developer labels Sep 15, 2022
@MohitGupta121 MohitGupta121 self-assigned this Feb 4, 2023
@MohitGupta121 MohitGupta121 mentioned this issue Feb 8, 2023
Closed
@MohitGupta121
Copy link
Member

@BenHenning We need to add these CI checks only for xml files or also for .kt files?

@BenHenning
Copy link
Member

@BenHenning We need to add these CI checks only for xml files or also for .kt files?

We should add the checks for both, but for Kotlin files we should focus on user-facing components: activities, activity presenters, fragments, fragment presenters, views, and view presenters.

@MohitGupta121 MohitGupta121 mentioned this issue Feb 24, 2023
Merged
6 tasks
@seanlip seanlip added enhancement End user-perceivable enhancements. and removed issue_type_infrastructure labels Mar 28, 2023
BenHenning pushed a commit that referenced this issue Apr 6, 2023
@MohitGupta121
Fixed #4396, #4883 : Add CI checks to ensure Kotlin files , Layout xm…
1bbadac 
…l files are only referencing colors from component_colors.xml (#4882)

<!-- READ ME FIRST: Please fill in the explanation section below and
check off every point from the Essential Checklist! -->
## Explanation

Fixed #4396 : Add CI checks to ensure Layout xml files are only
referencing colors from component_colors.xml

Fixed #4883 : Add CI checks to ensure Kotlin Files (Activities, Activity
Presenters, Fragments, Fragment Presenters, Views, and View Presenters)
are only referencing colors from component_colors.xml



<!--
- Explain what your PR does. If this PR fixes an existing bug, please
include
- "Fixes #bugnum:" in the explanation so that GitHub can auto-close the
issue
  - when this PR is merged.
  -->

## Essential Checklist
<!-- Please tick the relevant boxes by putting an "x" in them. -->
- [x] The PR title and explanation each start with "Fix #bugnum: " (If
this PR fixes part of an issue, prefix the title with "Fix part of
#bugnum: ...".)
- [x] Any changes to
[scripts/assets](https://github.com/oppia/oppia-android/tree/develop/scripts/assets)
files have their rationale included in the PR explanation.
- [x] The PR follows the [style
guide](https://github.com/oppia/oppia-android/wiki/Coding-style-guide).
- [x] The PR does not contain any unnecessary code changes from Android
Studio
([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#undo-unnecessary-changes)).
- [x] The PR is made from a branch that's **not** called "develop" and
is up-to-date with "develop".
- [x] The PR is **assigned** to the appropriate reviewers
([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#clarification-regarding-assignees-and-reviewers-section)).

## For UI-specific PRs only
<!-- Delete these section if this PR does not include UI-related
changes. -->
If your PR includes UI-related changes, then:
- Add screenshots for portrait/landscape for both a tablet & phone of
the before & after UI changes
- For the screenshots above, include both English and pseudo-localized
(RTL) screenshots (see [RTL
guide](https://github.com/oppia/oppia-android/wiki/RTL-Guidelines))
- Add a video showing the full UX flow with a screen reader enabled (see
[accessibility
guide](https://github.com/oppia/oppia-android/wiki/Accessibility-(A11y)-Guide))
- Add a screenshot demonstrating that you ran affected Espresso tests
locally & that they're passing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MohitGupta121 MohitGupta121

Labels
enhancement End user-perceivable enhancements. Impact: Low Low perceived user impact (e.g. edge cases). Issue: Needs Clarification Indicates that an issue needs more detail in order to be able to be acted upon. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
[Team] Core Learner and Mastery flows & UI Frontend - Android
Archived in project
Milestone
No milestone
5 participants
@seanlip @BenHenning @ayush0402 @MohitGupta121 @Broppia