Add Wiki documentation for adding the spotlight experience to any element #4460
Assignees
Labels
enhancement
End user-perceivable enhancements.
Impact: Low
Low perceived user impact (e.g. edge cases).
Z-ibt
Temporary label for Ben to keep track of issues he's triaged.
Comments
Broppia
added
issue_type_infrastructure
Impact: Low
BenHenning
added
Z-ibt
|
@JishnuGoyal has this been completed? |
|
Yes, this has been updated. PTAL. @BenHenning |
seanlip
added
enhancement
|
@JishnuGoyal Could you please add a link in this thread to the wiki documentation in question? |
|
Here is this link to the Spotlight Wiki doc: https://docs.google.com/document/d/1houcOoZLbTgdwnL1HnmocolEjP6exfY-R_qsNbYPY7Y/edit# I believe this is fully complete now. @BenHenning PTAL, thanks! |
|
@JishnuGoyal As discussed in chat, please make a PR to the oppia-android repo the usual way, and @BenHenning can review that directly. Note that the wiki pages are now stored within the repo, see https://github.com/oppia/oppia-android/tree/develop/wiki. Thanks! |
6 tasks
seanlip
pushed a commit
that referenced
this issue
Apr 27, 2023
… to any element (#4943) <!-- READ ME FIRST: Please fill in the explanation section below and check off every point from the Essential Checklist! --> ## Explanation <!-- - Explain what your PR does. If this PR fixes an existing bug, please include - "Fixes #bugnum:" in the explanation so that GitHub can auto-close the issue - when this PR is merged. --> Fixes #4460 This PR adds a new page to the Wiki explaining how Spotlights should be used, how new ones should be added and how should they be tested. ## Essential Checklist <!-- Please tick the relevant boxes by putting an "x" in them. --> - [x] The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".) - [x] Any changes to [scripts/assets](https://github.com/oppia/oppia-android/tree/develop/scripts/assets) files have their rationale included in the PR explanation. - [x] The PR follows the [style guide](https://github.com/oppia/oppia-android/wiki/Coding-style-guide). - [x] The PR does not contain any unnecessary code changes from Android Studio ([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#undo-unnecessary-changes)). - [x] The PR is made from a branch that's **not** called "develop" and is up-to-date with "develop". - [x] The PR is **assigned** to the appropriate reviewers ([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#clarification-regarding-assignees-and-reviewers-section)).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
No description provided.
The text was updated successfully, but these errors were encountered: