Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Dark Mode support for BottomSheetFragment (Exploration + Revision Card) #4513

Closed
vrajdesai78 opened this issue Aug 19, 2022 · 2 comments · Fixed by #4811 or #4812
Closed

Add Dark Mode support for BottomSheetFragment (Exploration + Revision Card) #4513

vrajdesai78 opened this issue Aug 19, 2022 · 2 comments · Fixed by #4811 or #4812
Assignees
@MohitGupta121
Labels
Impact: Low Low perceived user impact (e.g. edge cases). Issue: Needs Clarification Indicates that an issue needs more detail in order to be able to be acted upon. Z-ibt Temporary label for Ben to keep track of issues he's triaged.

Comments

@vrajdesai78
Copy link
Contributor

Add Dark Mode support for BottomSheetFragment in both Exploration and Revision Card.

Current UI

bottom-sheet.mp4
@vrajdesai78 vrajdesai78 mentioned this issue Aug 19, 2022
Merged
6 tasks
@BenHenning BenHenning added issue_type_bug Impact: Low Low perceived user impact (e.g. edge cases). Issue: Needs Clarification Indicates that an issue needs more detail in order to be able to be acted upon. Z-ibt Temporary label for Ben to keep track of issues he's triaged. labels Sep 15, 2022
@mahmood199
Copy link

Would like to work on this
can I be assigned to this?

@MohitGupta121 MohitGupta121 mentioned this issue Dec 2, 2022
Closed
@MohitGupta121 MohitGupta121 self-assigned this Dec 19, 2022
@MohitGupta121 MohitGupta121 mentioned this issue Dec 28, 2022
Merged
6 tasks
rt4914 pushed a commit that referenced this issue Dec 29, 2022
@MohitGupta121
Fixes #4513 : Dark mode implementation - Dialogs, Status Bar (#4811)
427ee79 
<!-- READ ME FIRST: Please fill in the explanation section below and
check off every point from the Essential Checklist! -->
## Explanation

Fixes #4513 : Dark mode implementation - Dialogs, Status Bar


<!--
- Explain what your PR does. If this PR fixes an existing bug, please
include
- "Fixes #bugnum:" in the explanation so that GitHub can auto-close the
issue
  - when this PR is merged.
  -->

## Essential Checklist
<!-- Please tick the relevant boxes by putting an "x" in them. -->
- [x] The PR title and explanation each start with "Fix #bugnum: " (If
this PR fixes part of an issue, prefix the title with "Fix part of
#bugnum: ...".)
- [ ] Any changes to
[scripts/assets](https://github.com/oppia/oppia-android/tree/develop/scripts/assets)
files have their rationale included in the PR explanation.
- [x] The PR follows the [style
guide](https://github.com/oppia/oppia-android/wiki/Coding-style-guide).
- [x] The PR does not contain any unnecessary code changes from Android
Studio
([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#undo-unnecessary-changes)).
- [x] The PR is made from a branch that's **not** called "develop" and
is up-to-date with "develop".
- [x] The PR is **assigned** to the appropriate reviewers
([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#clarification-regarding-assignees-and-reviewers-section)).

## For UI-specific PRs only


### Cellular Data Dialog

<img
src="https://user-images.githubusercontent.com/76530270/209852279-68fbc516-fe59-48d7-bb20-01d148c3bf01.png"
height="400" style="max-width: 100%"> <img
src="https://user-images.githubusercontent.com/76530270/209852405-af1ab87f-d4d0-4889-b783-b12e87921245.png"
height="400" style="max-width: 100%">


<img
src="https://user-images.githubusercontent.com/76530270/209852342-5b61c622-2049-4704-b6c9-e991f3a6d7f4.png"
height="400" style="max-width: 100%"> <img
src="https://user-images.githubusercontent.com/76530270/209852434-d76bd58c-40a1-404d-91b5-def39adad9bf.png"
height="400" style="max-width: 100%">


### Bottom Sheet Options Menu

<img
src="https://user-images.githubusercontent.com/76530270/209852825-a6f9e682-eb26-4141-9042-9025173524c7.png"
height="400" style="max-width: 100%"> <img
src="https://user-images.githubusercontent.com/76530270/209852662-d387b5c8-fa79-49a5-9d96-538ee260ce73.png"
height="400" style="max-width: 100%">


### Profile Picture Edit Dialog

<img
src="https://user-images.githubusercontent.com/76530270/209852979-cdd8e8e9-08df-40b5-b2d7-e4782f204184.png"
height="400" style="max-width: 100%"> <img
src="https://user-images.githubusercontent.com/76530270/209853058-bfec5792-bf9e-424a-8e5d-f7efd4cd85ef.png"
height="400" style="max-width: 100%">


### Reveal Solution Dialog

<img
src="https://user-images.githubusercontent.com/76530270/209854726-977bb254-6f9e-47e8-bc32-46c76bfc3c56.png"
height="400" style="max-width: 100%"> <img
src="https://user-images.githubusercontent.com/76530270/209854505-fcda3ba1-4bd0-4113-b44e-829be12ab87a.png"
height="400" style="max-width: 100%">


### Full Screen Dialogs 

#### Concept Card Dialog

<img
src="https://user-images.githubusercontent.com/76530270/209855322-a9e4e052-689a-4c95-b74d-d163e2e033c6.png"
height="400" style="max-width: 100%"> <img
src="https://user-images.githubusercontent.com/76530270/209855491-3acb57f0-536d-46ef-8700-c4e6649dd066.png"
height="400" style="max-width: 100%">


#### Hint and Solutions Dialog

<img
src="https://user-images.githubusercontent.com/76530270/209855664-215ddf21-3025-4a9f-bb64-121f1f3e32e4.png"
height="400" style="max-width: 100%"> <img
src="https://user-images.githubusercontent.com/76530270/209855770-ac43b78a-a46b-4591-ae1f-b44785b9fb76.png"
height="400" style="max-width: 100%">


<!-- Delete these section if this PR does not include UI-related
changes. -->
If your PR includes UI-related changes, then:
- Add screenshots for portrait/landscape for both a tablet & phone of
the before & after UI changes
- For the screenshots above, include both English and pseudo-localized
(RTL) screenshots (see [RTL
guide](https://github.com/oppia/oppia-android/wiki/RTL-Guidelines))
- Add a video showing the full UX flow with a screen reader enabled (see
[accessibility
guide](https://github.com/oppia/oppia-android/wiki/Accessibility-(A11y)-Guide))
- Add a screenshot demonstrating that you ran affected Espresso tests
locally & that they're passing
@github-actions github-actions bot reopened this Dec 29, 2022
@github-actions
Copy link

The issue is reopened because of the following unresolved TODOs:

oppia-android/app/src/main/res/layout/bottom_sheet_options_menu_fragment.xml

Line 1 in 427ee79

<?xml version="1.0" encoding="utf-8"?><!-- TODO(#4513): Add dark mode support for BottomSheet. -->

@MohitGupta121 MohitGupta121 mentioned this issue Dec 29, 2022
Merged
6 tasks
rt4914 pushed a commit that referenced this issue Dec 29, 2022
@MohitGupta121
Fixes #4513 : Dark mode implementation - BottomSheetFragment (Explora…
fdd9ec8 
…tion + Revision Card) (#4812)

<!-- READ ME FIRST: Please fill in the explanation section below and
check off every point from the Essential Checklist! -->
## Explanation

Fixes #4513 : Dark mode implementation - BottomSheetFragment
(Exploration + Revision Card)


<!--
- Explain what your PR does. If this PR fixes an existing bug, please
include
- "Fixes #bugnum:" in the explanation so that GitHub can auto-close the
issue
  - when this PR is merged.
  -->

## Essential Checklist
<!-- Please tick the relevant boxes by putting an "x" in them. -->
- [x] The PR title and explanation each start with "Fix #bugnum: " (If
this PR fixes part of an issue, prefix the title with "Fix part of
#bugnum: ...".)
- [ ] Any changes to
[scripts/assets](https://github.com/oppia/oppia-android/tree/develop/scripts/assets)
files have their rationale included in the PR explanation.
- [x] The PR follows the [style
guide](https://github.com/oppia/oppia-android/wiki/Coding-style-guide).
- [x] The PR does not contain any unnecessary code changes from Android
Studio
([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#undo-unnecessary-changes)).
- [x] The PR is made from a branch that's **not** called "develop" and
is up-to-date with "develop".
- [x] The PR is **assigned** to the appropriate reviewers
([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#clarification-regarding-assignees-and-reviewers-section)).

## For UI-specific PRs only

### Bottom Sheet Options Menu

<img
src="https://user-images.githubusercontent.com/76530270/209852825-a6f9e682-eb26-4141-9042-9025173524c7.png"
height="400" style="max-width: 100%"> <img
src="https://user-images.githubusercontent.com/76530270/209852662-d387b5c8-fa79-49a5-9d96-538ee260ce73.png"
height="400" style="max-width: 100%">



<!-- Delete these section if this PR does not include UI-related
changes. -->
If your PR includes UI-related changes, then:
- Add screenshots for portrait/landscape for both a tablet & phone of
the before & after UI changes
- For the screenshots above, include both English and pseudo-localized
(RTL) screenshots (see [RTL
guide](https://github.com/oppia/oppia-android/wiki/RTL-Guidelines))
- Add a video showing the full UX flow with a screen reader enabled (see
[accessibility
guide](https://github.com/oppia/oppia-android/wiki/Accessibility-(A11y)-Guide))
- Add a screenshot demonstrating that you ran affected Espresso tests
locally & that they're passing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MohitGupta121 MohitGupta121

Labels
Impact: Low Low perceived user impact (e.g. edge cases). Issue: Needs Clarification Indicates that an issue needs more detail in order to be able to be acted upon. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
[Team] Core Learner and Mastery flows & UI Frontend - Android
Archived in project
Milestone
No milestone
4 participants
@BenHenning @vrajdesai78 @mahmood199 @MohitGupta121