Doesn't have Dark Mode Mock for the newly implemented Text view in audio_fragment.xml. #4561
Assignees
Labels
Impact: Low
Low perceived user impact (e.g. edge cases).
Z-ibt
Temporary label for Ben to keep track of issues he's triaged.
Comments
BenHenning
added
issue_type_bug
Impact: Low
|
can i work on this feature ? |
|
This seems to be available to work on @iampradeep-hr if you're still interested (given that you asked on other issue threads--you should start with one issue rather than multiple). |
BenHenning
moved this to Todo
in [Team] Core Learner and Mastery flows & UI Frontend - Android
6 tasks
rt4914
moved this from Todo
to In Progress
in [Team] Core Learner and Mastery flows & UI Frontend - Android
github-project-automation
bot
moved this from In Progress
to Done
in [Team] Core Learner and Mastery flows & UI Frontend - Android
rt4914
pushed a commit
that referenced
this issue
Jan 3, 2023
<!-- READ ME FIRST: Please fill in the explanation section below and check off every point from the Essential Checklist! --> ## Explanation Fixes #4561 : Dark mode implementation - Audio Player <!-- - Explain what your PR does. If this PR fixes an existing bug, please include - "Fixes #bugnum:" in the explanation so that GitHub can auto-close the issue - when this PR is merged. --> ## Essential Checklist <!-- Please tick the relevant boxes by putting an "x" in them. --> - [x] The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".) - [ ] Any changes to [scripts/assets](https://github.com/oppia/oppia-android/tree/develop/scripts/assets) files have their rationale included in the PR explanation. - [x] The PR follows the [style guide](https://github.com/oppia/oppia-android/wiki/Coding-style-guide). - [x] The PR does not contain any unnecessary code changes from Android Studio ([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#undo-unnecessary-changes)). - [x] The PR is made from a branch that's **not** called "develop" and is up-to-date with "develop". - [x] The PR is **assigned** to the appropriate reviewers ([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#clarification-regarding-assignees-and-reviewers-section)). ## For UI-specific PRs only ### Audio Player <img src="https://user-images.githubusercontent.com/76530270/210343312-a406c318-87fb-4c81-8ea9-20fb0f1a14e4.png" height="400" style="max-width: 100%"> <img src="https://user-images.githubusercontent.com/76530270/210343451-ddf373da-d4b4-4ecd-93ad-aa09f2809198.png" height="400" style="max-width: 100%"> <!-- Delete these section if this PR does not include UI-related changes. --> If your PR includes UI-related changes, then: - Add screenshots for portrait/landscape for both a tablet & phone of the before & after UI changes - For the screenshots above, include both English and pseudo-localized (RTL) screenshots (see [RTL guide](https://github.com/oppia/oppia-android/wiki/RTL-Guidelines)) - Add a video showing the full UX flow with a screen reader enabled (see [accessibility guide](https://github.com/oppia/oppia-android/wiki/Accessibility-(A11y)-Guide)) - Add a screenshot demonstrating that you ran affected Espresso tests locally & that they're passing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Newly Implemented TextView doesn't have Dark Mode Mock in the audio_fragment.xml.
To Reproduce
Steps to reproduce the behavior:
audio_fragment.xmlThe text was updated successfully, but these errors were encountered: