[RunAllTests] Remove caching for Bazel CI workflows #2884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove caching from Bazel tests.
Remove caching for Bazel builds.
|
@seanlip @rt4914 @anandwana001 assigning this broadly to try and get the PR in sooner since it's a priority. Please feel free to let it get auto-merged if any of you approve it (no need for more than one approval here, I think). Please reach out if you have any questions or concerns. |
BenHenning
changed the title
|
(or not?) EDIT: Ah, ignore that. I was confused about why the PR got closed, which is explained in the next comment. |
|
Restarting CI to force Bazel tests to run to verify that they are actually not using caching anymore. |
BenHenning
commented
Mar 11, 2021
BenHenning
commented
Mar 11, 2021
BenHenning
commented
Mar 11, 2021
BenHenning
commented
Mar 11, 2021
BenHenning
commented
Mar 11, 2021
BenHenning
commented
Mar 11, 2021
BenHenning
commented
Mar 11, 2021
BenHenning
commented
Mar 11, 2021
Fix environment variable conditions.
|
Thanks for the super fast review @seanlip! |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bazel caching is currently not cost effective: it only caches 25-30% of actions, and we're not seeing worthwhile performance benefits from it. This PR makes caching configurable for both unit tests and binary builds, and disables it for CI workflows. #1861 is tracking improving this over time, including upstream patching Bazel itself to fix some of the caching issues. We may revisit
reenabling caching at that time.
Runs verifying that caching is now disabled:
Builds
Unit tests
