Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #4381: Different shades of fillColor used in portrait and landscape #4479

Closed

Conversation

Joaquin144
Copy link

@Joaquin144 Joaquin144 commented Jul 29, 2022

Explanation

Fixes #4381: Handles the inconsistent colors In 4 onboarding screen slides across tablet, mobile portrait, mobile landscape layouts.

Essential Checklist

  • The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • Any changes to scripts/assets files have their rationale included in the PR explanation.
  • The PR follows the style guide.
  • The PR does not contain any unnecessary code changes from Android Studio (reference).
  • The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
  • The PR is assigned to the appropriate reviewers (reference).

For UI-specific PRs only

If your PR includes UI-related changes, then:

  • Add screenshots for portrait/landscape for both a tablet & phone of the before & after UI changes
  • For the screenshots above, include both English and pseudo-localized (RTL) screenshots (see RTL guide)
  • Add a video showing the full UX flow with a screen reader enabled (see accessibility guide)
  • Add a screenshot demonstrating that you ran affected Espresso tests locally & that they're passing

Android Redmi Note 11T 5G
Before and After Screenshots:--

Before/ After Screenshots for Tablet Nexus 10 API 22 ( Emulator ):----

After screenshots for tablet. Unfortunately can't attach before screenshots for tablet (due to performance issues in my PC due to which emulator is not working )

@Joaquin144 Joaquin144 requested a review from rt4914 as a code owner July 29, 2022 11:31
@Joaquin144 Joaquin144 changed the title Fill color onboarding screen Fixe #4381: Different shades of fillColor used in portrait and landscape Aug 1, 2022
@Joaquin144 Joaquin144 changed the title Fixe #4381: Different shades of fillColor used in portrait and landscape Fix #4381: Different shades of fillColor used in portrait and landscape Aug 2, 2022
@Joaquin144 Joaquin144 changed the title Fix #4381: Different shades of fillColor used in portrait and landscape Fixes #4381: Different shades of fillColor used in portrait and landscape Aug 3, 2022
@BenHenning BenHenning self-assigned this Aug 8, 2022
@oppiabot
Copy link

oppiabot bot commented Aug 15, 2022

Hi @Joaquin144, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue.
If you are still working on this PR, please make a follow-up commit within 3 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you!

@oppiabot oppiabot bot added the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Aug 15, 2022
@oppiabot oppiabot bot closed this Aug 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale Corresponds to items that haven't seen a recent update and may be automatically closed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Different shades of fillColor used in portrait and landscape of ic_onboarding_2.xml
2 participants