-
Notifications
You must be signed in to change notification settings - Fork 529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #4445: Add scaling animation for Continue button #4568
Fix #4445: Add scaling animation for Continue button #4568
Conversation
# Conflicts: # domain/src/main/java/org/oppia/android/domain/platformparameter/PlatformParameterModule.kt
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @JishnuGoyal. Just had a few follow-up comments, but I think there are still 3 old conversations not yet resolved. Please make sure to resolve these.
Also, CI checks look like they're failing. PTAL.
app/src/main/java/org/oppia/android/app/customview/ContinueButtonView.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/oppia/android/app/customview/ContinueButtonView.kt
Outdated
Show resolved
Hide resolved
domain/src/test/java/org/oppia/android/domain/profile/ProfileManagementControllerTest.kt
Outdated
Show resolved
Hide resolved
domain/src/main/java/org/oppia/android/domain/profile/ProfileManagementController.kt
Outdated
Show resolved
Hide resolved
domain/src/main/java/org/oppia/android/domain/profile/ProfileManagementController.kt
Outdated
Show resolved
Hide resolved
testing/src/main/java/org/oppia/android/testing/profile/ProfileTestHelper.kt
Outdated
Show resolved
Hide resolved
testing/src/main/java/org/oppia/android/testing/profile/ProfileTestHelper.kt
Outdated
Show resolved
Hide resolved
testing/src/main/java/org/oppia/android/testing/profile/ProfileTestHelper.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JishnuGoyal I have checked the implementation and also the code and it does look good for code-owner files.
I have one major suggestion:
The animation for continue button is needed so as to bring users attention to it. So I think some similar thing should be done for non-sighted users too. I was thinking when you start the animation for continue button, at that time the screen-reader can speak some thing which brings users attention like "Navigate and click continue button to visit next screen".
@BenHenning Any thoughts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @JishnuGoyal! Just one small nit left--PTAL.
@JishnuGoyal I have checked the implementation and also the code and it does look good for code-owner files.
I have one major suggestion: The animation for continue button is needed so as to bring users attention to it. So I think some similar thing should be done for non-sighted users too. I was thinking when you start the animation for continue button, at that time the screen-reader can speak some thing which brings users attention like "Navigate and click continue button to visit next screen".
@BenHenning Any thoughts?
@rt4914 my only concern with this is that it may change the "default ordering" managed by a screenreader. I think your point is definitely valid if we consider this animation essential to progress (since relying on only visual cues isn't a broadly accessible way of doing things). However, perhaps a cleaner way might be to have a better content description for the continue button since it's more likely that a screenreader user will move through the entire view (and thus not miss something). Given this difference in usage, this may be worth exploring in the future if we get feedback that screenreader users are also getting confused sometimes on their first time through the lesson.
app/src/main/java/org/oppia/android/app/customview/ContinueButtonView.kt
Outdated
Show resolved
Hide resolved
testing/src/main/java/org/oppia/android/testing/profile/ProfileTestHelper.kt
Outdated
Show resolved
Hide resolved
testing/src/main/java/org/oppia/android/testing/profile/ProfileTestHelper.kt
Outdated
Show resolved
Hide resolved
testing/src/main/java/org/oppia/android/testing/profile/ProfileTestHelper.kt
Outdated
Show resolved
Hide resolved
…tonView.kt nit Co-authored-by: Ben Henning <henning.benmax@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @JishnuGoyal. LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JishnuGoyal Approving as @BenHenning suggestion does make sense for A11Y. Thanks.
Explanation
Fixes #4445
This PR is part of the GSoC project: Interactive Onboarding Flow which fixes #4445. It does so by creating a new custom view which connects to the
ContinueInteractionItemViewModel
, which receives a flag to start animating from the explorationProgressController. We wait for 45 seconds when the first card of a lesson is opened by the user, and then start the animation for the continue button.Essential Checklist
For UI-specific PRs only
If your PR includes UI-related changes, then:
Screenrecording_20221118_043637.mp4