Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #3169:Item selection interaction text should change on selection #4585

Conversation

Akshatkamboj14
Copy link
Member

Explanation

Fixes #3169

Essential Checklist

  • The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • Any changes to scripts/assets files have their rationale included in the PR explanation.
  • The PR follows the style guide.
  • The PR does not contain any unnecessary code changes from Android Studio (reference).
  • The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
  • The PR is assigned to the appropriate reviewers (reference).

For UI-specific PRs only

If your PR includes UI-related changes, then:

  • Add screenshots for portrait/landscape for both a tablet & phone of the before & after UI changes
  • For the screenshots above, include both English and pseudo-localized (RTL) screenshots (see RTL guide)
  • Add a video showing the full UX flow with a screen reader enabled (see accessibility guide)
  • Add a screenshot demonstrating that you ran affected Espresso tests locally & that they're passing

@Akshatkamboj14
Copy link
Member Author

hey, @BenHenning I have done the text changing part but I have a query in the disable selections when the max no. of selections are done by the user so I want to know how I am supposed to take the list of selections that are left after the user selects max no of selections and we are using custom recyclerView for the SelectionInteractionView so I Dont think like isEnabled = true function will work in this Custom Recyclerview or not?

@BenHenning
Copy link
Member

hey, @BenHenning I have done the text changing part but I have a query in the disable selections when the max no. of selections are done by the user so I want to know how I am supposed to take the list of selections that are left after the user selects max no of selections and we are using custom recyclerView for the SelectionInteractionView so I Dont think like isEnabled = true function will work in this Custom Recyclerview or not?

@Akshatkamboj14 I think you're going to need to conditionally disable only the checkboxes that are not currently selected, probably using something like a LiveData with selected indexes that's passed down to all checkbox item view models so that they can condition their enabled/disabled state. Enabling/disabling the whole RecyclerView wouldn't work since the user needs to be able to unselected selected items if they wish to change their selection.

@Akshatkamboj14
Copy link
Member Author

Okay, I'll try this approach.

@oppiabot
Copy link

oppiabot bot commented Sep 24, 2022

Hi @Akshatkamboj14, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue.
If you are still working on this PR, please make a follow-up commit within 3 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you!

@oppiabot oppiabot bot added the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Sep 24, 2022
@oppiabot oppiabot bot closed this Oct 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale Corresponds to items that haven't seen a recent update and may be automatically closed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ItemSelectionInteraction text change on selection
2 participants