Fix #4765: The Continue animation isn't interactive #4814

JishnuGoyal · 2022-12-30T09:17:30Z

Explanation

Demo Video:

Screenrecording_20221229_231926.mp4

This PR tries to handle the problem of the continue interaction button's animation not being eye-catching to the users. Currently, it does so by changing the animation to a shake animation. The button now does a little wobble, starting 45s after the screen is shown. It wobbles 2 times, and then repeats the animation after every 8 seconds.

Only with further testing and trial, will we know how the animation appeals to the users and resolves the problem at hand.

Technical detail:
The anim file (xml) is set to play the animation 2 times.
In the ContinueButtonView.kt file, the startAnimating() function has been made recursive, which calls itself after every 8 seconds in order to repeat the animation. The 8 second gap is achieved using the lifeCycleSafeTimerFactory.

Essential Checklist

The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
Any changes to scripts/assets files have their rationale included in the PR explanation.
The PR follows the style guide.
The PR does not contain any unnecessary code changes from Android Studio (reference).
The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
The PR is assigned to the appropriate reviewers (reference).

For UI-specific PRs only

github-actions · 2022-12-30T09:17:41Z

Thanks for submitting this pull request! Some main reviewers
have taken time off for the next few weeks, so it may take a
little while before we can look at this PR. We appreciate your
patience while some of our team members recharge. We'll be fully
returning on 10 January 2022.

oppiabot · 2023-01-06T09:42:42Z

Hi @JishnuGoyal, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue.
If you are still working on this PR, please make a follow-up commit within 3 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you!

BenHenning

Thanks @JishnuGoyal. Left one follow-up comment. Will follow up on the animation specifically in a follow-up comment.

app/src/main/java/org/oppia/android/app/customview/ContinueButtonView.kt

BenHenning · 2023-01-11T00:19:00Z

So I definitely think the wobble is better than the pulsing. It still has a disadvantage in that the touch target is moving, but it's much less likely to introduce clicking issues here than with the previous animation. I'm less certain about the 8 second delay between the animations--that seems a bit long.

@seanlip do you have any thoughts on the updated animation?

seanlip · 2023-01-11T00:49:11Z

I think the updated animation looks fine -- let's go with it. I think the 8-second delay is OK since this isn't meant to be as "in your face".

JishnuGoyal · 2023-01-16T09:57:35Z

PTAL @BenHenning. Going with the current animation per the suggestion given by Sean.

oppiabot · 2023-01-16T10:00:40Z

Unassigning @JishnuGoyal since a re-review was requested. @JishnuGoyal, please make sure you have addressed all review comments. Thanks!

oppiabot · 2023-01-23T10:46:56Z

Hi @JishnuGoyal, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue.
If you are still working on this PR, please make a follow-up commit within 3 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you!

BenHenning

Thanks @seanlip and @JishnuGoyal.

@JishnuGoyal the PR LGTM. There's one comment for you to resolve (I'm fine with you marking it as resolved once it's addressed one way or the other), and I think the PR needs to be updated with the latest develop before it can be merged. You'll also need @rt4914's approval for the XML changes.

app/src/main/java/org/oppia/android/app/customview/ContinueButtonView.kt

rt4914

Really nice and elegant solution. Thanks @JishnuGoyal

rt4914

Meant to approve it.

JishnuGoyal · 2023-01-27T18:47:04Z

Thank you so much @rt4914! Glad to hear this! <3
PTAL @BenHenning, left a reply to the review comment, will do as you suggest this time :)

BenHenning · 2023-01-31T22:53:42Z

Thanks @JishnuGoyal. Sent a follow-up comment--happy to defer to your decision here.

JishnuGoyal · 2023-02-01T11:18:26Z

Thanks Ben! I have left a reply on the last review thread. I suggest going with the current implementation itself since the function signature doesn't seem to match. PTAL @BenHenning.

oppiabot · 2023-02-01T11:21:30Z

Unassigning @JishnuGoyal since a re-review was requested. @JishnuGoyal, please make sure you have addressed all review comments. Thanks!

BenHenning

Thanks @JishnuGoyal. LGTM.

app/src/main/java/org/oppia/android/app/customview/ContinueButtonView.kt

## Explanation Fixes oppia#4765 Demo Video: https://user-images.githubusercontent.com/64526117/210055420-016f2dd2-46d6-4166-ae2a-be4c98710299.mp4 This PR tries to handle the problem of the continue interaction button's animation not being eye-catching to the users. Currently, it does so by changing the animation to a shake animation. The button now does a little wobble, starting 45s after the screen is shown. It wobbles 2 times, and then repeats the animation after every 8 seconds. Only with further testing and trial, will we know how the animation appeals to the users and resolves the problem at hand. **Technical detail:** The anim file (xml) is set to play the animation 2 times. In the `ContinueButtonView.kt` file, the startAnimating() function has been made recursive, which calls itself after every 8 seconds in order to repeat the animation. The 8 second gap is achieved using the lifeCycleSafeTimerFactory. ## Essential Checklist  - [x] The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".) - [x] Any changes to [scripts/assets](https://github.com/oppia/oppia-android/tree/develop/scripts/assets) files have their rationale included in the PR explanation. - [x] The PR follows the [style guide](https://github.com/oppia/oppia-android/wiki/Coding-style-guide). - [x] The PR does not contain any unnecessary code changes from Android Studio ([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#undo-unnecessary-changes)). - [x] The PR is made from a branch that's **not** called "develop" and is up-to-date with "develop". - [x] The PR is **assigned** to the appropriate reviewers ([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#clarification-regarding-assignees-and-reviewers-section)). ## For UI-specific PRs only

JishnuGoyal added 5 commits December 29, 2022 23:15

modify animation

06fbee7

modify animation

c4c6cfc

lint

7f9c5e0

refactor file name

89f4991

add helpful hint

f2badb5

JishnuGoyal requested review from BenHenning and rt4914 as code owners December 30, 2022 09:17

Merge branch 'develop' into cont_btn_anim

872b2ae

JishnuGoyal assigned rt4914 and BenHenning Dec 30, 2022

oppiabot bot added stale Corresponds to items that haven't seen a recent update and may be automatically closed. and removed stale Corresponds to items that haven't seen a recent update and may be automatically closed. labels Jan 6, 2023

BenHenning reviewed Jan 11, 2023

View reviewed changes

app/src/main/java/org/oppia/android/app/customview/ContinueButtonView.kt Outdated Show resolved Hide resolved

BenHenning assigned seanlip and JishnuGoyal and unassigned BenHenning Jan 11, 2023

seanlip removed their assignment Jan 11, 2023

lint

d678136

JishnuGoyal added 2 commits January 16, 2023 15:29

lint

a770179

Merge remote-tracking branch 'origin/cont_btn_anim' into cont_btn_anim

f1d7df0

oppiabot bot assigned BenHenning and unassigned JishnuGoyal Jan 16, 2023

Merge branch 'develop' into cont_btn_anim

b313487

oppiabot bot added the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Jan 23, 2023

BenHenning approved these changes Jan 24, 2023

View reviewed changes

app/src/main/java/org/oppia/android/app/customview/ContinueButtonView.kt Outdated Show resolved Hide resolved

oppiabot bot removed the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Jan 24, 2023

BenHenning assigned JishnuGoyal and unassigned BenHenning Jan 24, 2023

rt4914 suggested changes Jan 26, 2023

View reviewed changes

rt4914 approved these changes Jan 26, 2023

View reviewed changes

rt4914 removed their assignment Jan 26, 2023

oppiabot bot added the PR: LGTM label Jan 26, 2023

Merge branch 'develop' into cont_btn_anim

a4aa689

JishnuGoyal assigned BenHenning and unassigned JishnuGoyal Jan 27, 2023

oppiabot bot assigned rt4914 Jan 27, 2023

rt4914 removed their assignment Jan 30, 2023

BenHenning assigned JishnuGoyal and unassigned BenHenning Jan 31, 2023

Merge branch 'develop' into cont_btn_anim

7886ab1

oppiabot bot assigned BenHenning and unassigned JishnuGoyal Feb 1, 2023

BenHenning approved these changes Feb 1, 2023

View reviewed changes

app/src/main/java/org/oppia/android/app/customview/ContinueButtonView.kt Outdated Show resolved Hide resolved

BenHenning merged commit d578a96 into oppia:develop Feb 1, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix #4765: The Continue animation isn't interactive #4814

Fix #4765: The Continue animation isn't interactive #4814

JishnuGoyal commented Dec 30, 2022 •

edited

Loading

github-actions bot commented Dec 30, 2022

oppiabot bot commented Jan 6, 2023

BenHenning left a comment

BenHenning commented Jan 11, 2023

seanlip commented Jan 11, 2023

JishnuGoyal commented Jan 16, 2023

oppiabot bot commented Jan 16, 2023

oppiabot bot commented Jan 23, 2023

BenHenning left a comment

rt4914 left a comment

rt4914 left a comment

JishnuGoyal commented Jan 27, 2023

BenHenning commented Jan 31, 2023

JishnuGoyal commented Feb 1, 2023

oppiabot bot commented Feb 1, 2023

BenHenning left a comment

Fix #4765: The Continue animation isn't interactive #4814

Fix #4765: The Continue animation isn't interactive #4814

Conversation

JishnuGoyal commented Dec 30, 2022 • edited Loading

Explanation

Essential Checklist

For UI-specific PRs only

github-actions bot commented Dec 30, 2022

oppiabot bot commented Jan 6, 2023

BenHenning left a comment

Choose a reason for hiding this comment

BenHenning commented Jan 11, 2023

seanlip commented Jan 11, 2023

JishnuGoyal commented Jan 16, 2023

oppiabot bot commented Jan 16, 2023

oppiabot bot commented Jan 23, 2023

BenHenning left a comment

Choose a reason for hiding this comment

rt4914 left a comment

Choose a reason for hiding this comment

rt4914 left a comment

Choose a reason for hiding this comment

JishnuGoyal commented Jan 27, 2023

BenHenning commented Jan 31, 2023

JishnuGoyal commented Feb 1, 2023

oppiabot bot commented Feb 1, 2023

BenHenning left a comment

Choose a reason for hiding this comment

JishnuGoyal commented Dec 30, 2022 •

edited

Loading