Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #4833, #4834, #4835, #4838, #1050, #4519, #4522, #4837, #4836, #4855, #4856: Assorted alpha MR6 fixes #4846

Merged
merged 45 commits into from
Mar 10, 2023

Commits on Jun 16, 2022

  1. SW translation fixes + better UI.

    This fixes a bunch of Swahili string bugs by stripping out unnecessary
    prefixed whitespace.
    
    This also introduces a fast language switch bar between English and
    Swahili. It's not currently tested or gated behind a platform flag, but
    both of these will be changed if the team decides to proceed with this
    solution.
    BenHenning committed Jun 16, 2022
    Configuration menu
    Copy the full SHA
    b39e47d View commit details
    Browse the repository at this point in the history

Commits on Aug 24, 2022

  1. Expand concept card support.

    This adds support for opening concept cards from hints, solutions, and
    other concept cards.
    BenHenning committed Aug 24, 2022
    Configuration menu
    Copy the full SHA
    f2cbc0d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    2e62688 View commit details
    Browse the repository at this point in the history
  3. Lint fixes.

    BenHenning committed Aug 24, 2022
    Configuration menu
    Copy the full SHA
    76d38ed View commit details
    Browse the repository at this point in the history

Commits on Aug 25, 2022

  1. Configuration menu
    Copy the full SHA
    94a4140 View commit details
    Browse the repository at this point in the history

Commits on Jan 12, 2023

  1. Merge branch 'develop' into assorted-alpha-mr6-fixes

    Conflicts:
    	app/src/main/java/org/oppia/android/app/player/state/StateFragmentPresenter.kt
    	app/src/main/res/layout/state_fragment.xml
    	app/src/main/res/values-sw/strings.xml
    	app/src/main/res/values/untranslated_strings.xml
    BenHenning committed Jan 12, 2023
    Configuration menu
    Copy the full SHA
    7322714 View commit details
    Browse the repository at this point in the history
  2. Fixes a few things for the upcoming MR6 release.

    Fixes:
    - Removed extra spacing around a few Swahili strings (all should now be
    fixed).
    - Replaced 'reveal' English wording with 'show'.
    - Added a new event for logging voiceover pausing.
    - Updated the play/pause voiceover events to include language codes.
    
    Documentation and/or tests may not yet be completed.
    BenHenning committed Jan 12, 2023
    Configuration menu
    Copy the full SHA
    19f0e69 View commit details
    Browse the repository at this point in the history
  3. Merge branch 'expand-concept-card-support' into assorted-alpha-mr6-fixes

    Conflicts:
    	app/src/main/java/org/oppia/android/app/hintsandsolution/HintsAndSolutionDialogFragmentPresenter.kt
    	app/src/main/java/org/oppia/android/app/player/exploration/ExplorationActivity.kt
    	app/src/main/java/org/oppia/android/app/topic/conceptcard/ConceptCardFragmentPresenter.kt
    	domain/src/main/assets/test_exp_id_2.json
    	domain/src/main/assets/test_exp_id_2.textproto
    BenHenning committed Jan 12, 2023
    Configuration menu
    Copy the full SHA
    17efba6 View commit details
    Browse the repository at this point in the history

Commits on Jan 13, 2023

  1. Add mark chapter supported for admins.

    With the learner study parameter enabled, admins can now force-complete
    lessons on a per-profile basis for all profiles in the app. This
    leverages the existing developer-only options menu so this isn't
    something we would want to incorporate in the long-term without more
    refinement (none of the UI strings are even translated).
    BenHenning committed Jan 13, 2023
    Configuration menu
    Copy the full SHA
    b58c798 View commit details
    Browse the repository at this point in the history

Commits on Jan 14, 2023

  1. Fix in-lesson language switching.

    This also adds Swahili translations for test topic 0. Some style changes
    including support for a secondary button type. Updated the in-lesson
    language switcher to use this style & to be gated behind the learner
    study platform parameter.
    
    And, fixes hint & solution header expanding to be the whole header and
    not the whole card.
    BenHenning committed Jan 14, 2023
    Configuration menu
    Copy the full SHA
    a502725 View commit details
    Browse the repository at this point in the history

Commits on Jan 18, 2023

  1. Add support for multiple solution types.

    This also includes a rebuild of much of the hint/solution data flow
    since the previous version had a lot of unnecessary complexity. It also
    redefines the internal representation for solution answers (which makes
    them type-safe during data retrieval time).
    BenHenning committed Jan 18, 2023
    Configuration menu
    Copy the full SHA
    50615ab View commit details
    Browse the repository at this point in the history

Commits on Jan 19, 2023

  1. Lint & static check fixes.

    BenHenning committed Jan 19, 2023
    Configuration menu
    Copy the full SHA
    970dfaf View commit details
    Browse the repository at this point in the history
  2. Remove TODO for soon-to-be-fixed issue.

    (The intent of this issue is being tracked separately and will be
    addressed on this branch in a follow-up commit).
    BenHenning committed Jan 19, 2023
    Configuration menu
    Copy the full SHA
    a3efa90 View commit details
    Browse the repository at this point in the history
  3. Merge branch 'develop' into assorted-alpha-mr6-fixes

    Conflicts:
    	app/src/main/res/drawable/secondary_button_background.xml
    	app/src/main/res/layout/state_fragment.xml
    	app/src/main/res/values/component_colors.xml
    	app/src/main/res/values/styles.xml
    BenHenning committed Jan 19, 2023
    Configuration menu
    Copy the full SHA
    1d0c122 View commit details
    Browse the repository at this point in the history
  4. Multiple fixes.

    This includes:
    - Post-merge fixes
    - A change to make the switch lang button container transparent so that
    the continue & submit buttons are still clickable through it
    - A fix to work around a databinding bug that can sometimes cause a
    crash that would be 100% reproducible for a specific build of the app
    (since it's a bytecode-level issue)
    BenHenning committed Jan 19, 2023
    Configuration menu
    Copy the full SHA
    20255ec View commit details
    Browse the repository at this point in the history
  5. Fix broken titles in subtopics after conversion.

    Also, clean up component_colors.xml (noticed during PR self-review) and
    miscellaneous other code health adjustments.
    BenHenning committed Jan 19, 2023
    Configuration menu
    Copy the full SHA
    62a3ab3 View commit details
    Browse the repository at this point in the history
  6. Catalog tests to add.

    BenHenning committed Jan 19, 2023
    Configuration menu
    Copy the full SHA
    3a2dee0 View commit details
    Browse the repository at this point in the history
  7. Fix test build breakages.

    BenHenning committed Jan 19, 2023
    Configuration menu
    Copy the full SHA
    c40d89b View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    87cd106 View commit details
    Browse the repository at this point in the history

Commits on Jan 20, 2023

  1. Add new tests.

    Also, fix a few issues that the new tests discovered.
    BenHenning committed Jan 20, 2023
    Configuration menu
    Copy the full SHA
    598a00c View commit details
    Browse the repository at this point in the history
  2. Fix broken Gradle tests.

    BenHenning committed Jan 20, 2023
    Configuration menu
    Copy the full SHA
    c109c7c View commit details
    Browse the repository at this point in the history
  3. Address reviewer comments.

    BenHenning committed Jan 20, 2023
    Configuration menu
    Copy the full SHA
    51b83f3 View commit details
    Browse the repository at this point in the history
  4. Update version.bzl

    BenHenning authored Jan 20, 2023
    Configuration menu
    Copy the full SHA
    afc3817 View commit details
    Browse the repository at this point in the history
  5. Assorted fixes.

    - Fixes a test broken in Gradle.
    - Repurposes a now unused color for the new secondary button style.
    - Fixes landscape support in profile_edit_fragment for the new modify
    progress flow.
    BenHenning committed Jan 20, 2023
    Configuration menu
    Copy the full SHA
    8065e64 View commit details
    Browse the repository at this point in the history

Commits on Jan 26, 2023

  1. Configuration menu
    Copy the full SHA
    1346329 View commit details
    Browse the repository at this point in the history

Commits on Jan 30, 2023

  1. Many more fixes/changes per feedback.

    This includes:
    - Fixing image sizing issues
    - Fixing bullet/numbered list formatting issues
    - Moving the in-lesson Swahili language switcher to also be behind an
    admin-configurable per-profile setting
    - Logging a new event for when the in-lesson language switch button is
    clicked
    - Logging a new event for when the user exits a revision card
    - Updating all events to include app/content/audio language settings for
    the user
    - Updating the in-lesson language switch button to only show if the
    content of a card is available in Swahili
    - Updating the switch-to-Swahili button's text to be in Swahili when the
    rest of the strings are in English
    - Fixing an issue with session ID to ensure it gets reset properly upon
    profile login
    - Fixing an issue where switching between tabs in the topic screen
    wasn't actually logging events for the switches
    - Introducing a new share button in the learner analytics screen to make
    it easier to record per-device IDs
    
    Miscellaneous other refactors and/or fixes were also done, as needed,
    and per feedback.
    BenHenning committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    39dafc0 View commit details
    Browse the repository at this point in the history
  2. Address reviewer comments.

    BenHenning committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    c0dc1a5 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    a1a33d4 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    5b220b7 View commit details
    Browse the repository at this point in the history
  5. Use latest commit for versioning, instead.

    Also, bump version codes to prepare for another Kenya-specific alpha
    re-release.
    BenHenning committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    6eaa68c View commit details
    Browse the repository at this point in the history
  6. Fix broken tests.

    Includes one small clean-up.
    BenHenning committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    a64d1a2 View commit details
    Browse the repository at this point in the history
  7. Fix more broken tests.

    These were missed in Bazel since test targets were never originally
    added for them.
    BenHenning committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    c021017 View commit details
    Browse the repository at this point in the history

Commits on Jan 31, 2023

  1. Configuration menu
    Copy the full SHA
    c64a91d View commit details
    Browse the repository at this point in the history
  2. Fix broken Gradle tests.

    BenHenning committed Jan 31, 2023
    Configuration menu
    Copy the full SHA
    c4ad811 View commit details
    Browse the repository at this point in the history
  3. Merge branch 'develop' into assorted-alpha-mr6-fixes

    Conflicts:
    	app/src/main/res/values/component_colors.xml
    BenHenning committed Jan 31, 2023
    Configuration menu
    Copy the full SHA
    3f12d91 View commit details
    Browse the repository at this point in the history

Commits on Feb 1, 2023

  1. Configuration menu
    Copy the full SHA
    b793d0d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    4a6b904 View commit details
    Browse the repository at this point in the history

Commits on Feb 28, 2023

  1. Configuration menu
    Copy the full SHA
    c8eb925 View commit details
    Browse the repository at this point in the history
  2. Update versions for a Kenya alpha re-release.

    Also, fix the version code ordering for KitKat/Lollipop versions
    (Lollipop should always take priority).
    BenHenning committed Feb 28, 2023
    Configuration menu
    Copy the full SHA
    a8f24c3 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    4539b0a View commit details
    Browse the repository at this point in the history

Commits on Mar 1, 2023

  1. Merge branch 'assorted-alpha-mr6-fixes' of github.com:oppia/oppia-and…

    …roid into assorted-alpha-mr6-fixes
    BenHenning committed Mar 1, 2023
    Configuration menu
    Copy the full SHA
    8cd35d9 View commit details
    Browse the repository at this point in the history

Commits on Mar 10, 2023

  1. Configuration menu
    Copy the full SHA
    e49a622 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ca3250e View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    3a8d645 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    245d48a View commit details
    Browse the repository at this point in the history