-
Notifications
You must be signed in to change notification settings - Fork 521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #4833, #4834, #4835, #4838, #1050, #4519, #4522, #4837, #4836, #4855, #4856: Assorted alpha MR6 fixes #4846
Commits on Jun 16, 2022
-
SW translation fixes + better UI.
This fixes a bunch of Swahili string bugs by stripping out unnecessary prefixed whitespace. This also introduces a fast language switch bar between English and Swahili. It's not currently tested or gated behind a platform flag, but both of these will be changed if the team decides to proceed with this solution.
Configuration menu - View commit details
-
Copy full SHA for b39e47d - Browse repository at this point
Copy the full SHA b39e47dView commit details
Commits on Aug 24, 2022
-
This adds support for opening concept cards from hints, solutions, and other concept cards.
Configuration menu - View commit details
-
Copy full SHA for f2cbc0d - Browse repository at this point
Copy the full SHA f2cbc0dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2e62688 - Browse repository at this point
Copy the full SHA 2e62688View commit details -
Configuration menu - View commit details
-
Copy full SHA for 76d38ed - Browse repository at this point
Copy the full SHA 76d38edView commit details
Commits on Aug 25, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 94a4140 - Browse repository at this point
Copy the full SHA 94a4140View commit details
Commits on Jan 12, 2023
-
Merge branch 'develop' into assorted-alpha-mr6-fixes
Conflicts: app/src/main/java/org/oppia/android/app/player/state/StateFragmentPresenter.kt app/src/main/res/layout/state_fragment.xml app/src/main/res/values-sw/strings.xml app/src/main/res/values/untranslated_strings.xml
Configuration menu - View commit details
-
Copy full SHA for 7322714 - Browse repository at this point
Copy the full SHA 7322714View commit details -
Fixes a few things for the upcoming MR6 release.
Fixes: - Removed extra spacing around a few Swahili strings (all should now be fixed). - Replaced 'reveal' English wording with 'show'. - Added a new event for logging voiceover pausing. - Updated the play/pause voiceover events to include language codes. Documentation and/or tests may not yet be completed.
Configuration menu - View commit details
-
Copy full SHA for 19f0e69 - Browse repository at this point
Copy the full SHA 19f0e69View commit details -
Merge branch 'expand-concept-card-support' into assorted-alpha-mr6-fixes
Conflicts: app/src/main/java/org/oppia/android/app/hintsandsolution/HintsAndSolutionDialogFragmentPresenter.kt app/src/main/java/org/oppia/android/app/player/exploration/ExplorationActivity.kt app/src/main/java/org/oppia/android/app/topic/conceptcard/ConceptCardFragmentPresenter.kt domain/src/main/assets/test_exp_id_2.json domain/src/main/assets/test_exp_id_2.textproto
Configuration menu - View commit details
-
Copy full SHA for 17efba6 - Browse repository at this point
Copy the full SHA 17efba6View commit details
Commits on Jan 13, 2023
-
Add mark chapter supported for admins.
With the learner study parameter enabled, admins can now force-complete lessons on a per-profile basis for all profiles in the app. This leverages the existing developer-only options menu so this isn't something we would want to incorporate in the long-term without more refinement (none of the UI strings are even translated).
Configuration menu - View commit details
-
Copy full SHA for b58c798 - Browse repository at this point
Copy the full SHA b58c798View commit details
Commits on Jan 14, 2023
-
Fix in-lesson language switching.
This also adds Swahili translations for test topic 0. Some style changes including support for a secondary button type. Updated the in-lesson language switcher to use this style & to be gated behind the learner study platform parameter. And, fixes hint & solution header expanding to be the whole header and not the whole card.
Configuration menu - View commit details
-
Copy full SHA for a502725 - Browse repository at this point
Copy the full SHA a502725View commit details
Commits on Jan 18, 2023
-
Add support for multiple solution types.
This also includes a rebuild of much of the hint/solution data flow since the previous version had a lot of unnecessary complexity. It also redefines the internal representation for solution answers (which makes them type-safe during data retrieval time).
Configuration menu - View commit details
-
Copy full SHA for 50615ab - Browse repository at this point
Copy the full SHA 50615abView commit details
Commits on Jan 19, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 970dfaf - Browse repository at this point
Copy the full SHA 970dfafView commit details -
Remove TODO for soon-to-be-fixed issue.
(The intent of this issue is being tracked separately and will be addressed on this branch in a follow-up commit).
Configuration menu - View commit details
-
Copy full SHA for a3efa90 - Browse repository at this point
Copy the full SHA a3efa90View commit details -
Merge branch 'develop' into assorted-alpha-mr6-fixes
Conflicts: app/src/main/res/drawable/secondary_button_background.xml app/src/main/res/layout/state_fragment.xml app/src/main/res/values/component_colors.xml app/src/main/res/values/styles.xml
Configuration menu - View commit details
-
Copy full SHA for 1d0c122 - Browse repository at this point
Copy the full SHA 1d0c122View commit details -
This includes: - Post-merge fixes - A change to make the switch lang button container transparent so that the continue & submit buttons are still clickable through it - A fix to work around a databinding bug that can sometimes cause a crash that would be 100% reproducible for a specific build of the app (since it's a bytecode-level issue)
Configuration menu - View commit details
-
Copy full SHA for 20255ec - Browse repository at this point
Copy the full SHA 20255ecView commit details -
Fix broken titles in subtopics after conversion.
Also, clean up component_colors.xml (noticed during PR self-review) and miscellaneous other code health adjustments.
Configuration menu - View commit details
-
Copy full SHA for 62a3ab3 - Browse repository at this point
Copy the full SHA 62a3ab3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3a2dee0 - Browse repository at this point
Copy the full SHA 3a2dee0View commit details -
Configuration menu - View commit details
-
Copy full SHA for c40d89b - Browse repository at this point
Copy the full SHA c40d89bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 87cd106 - Browse repository at this point
Copy the full SHA 87cd106View commit details
Commits on Jan 20, 2023
-
Also, fix a few issues that the new tests discovered.
Configuration menu - View commit details
-
Copy full SHA for 598a00c - Browse repository at this point
Copy the full SHA 598a00cView commit details -
Configuration menu - View commit details
-
Copy full SHA for c109c7c - Browse repository at this point
Copy the full SHA c109c7cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 51b83f3 - Browse repository at this point
Copy the full SHA 51b83f3View commit details -
Configuration menu - View commit details
-
Copy full SHA for afc3817 - Browse repository at this point
Copy the full SHA afc3817View commit details -
- Fixes a test broken in Gradle. - Repurposes a now unused color for the new secondary button style. - Fixes landscape support in profile_edit_fragment for the new modify progress flow.
Configuration menu - View commit details
-
Copy full SHA for 8065e64 - Browse repository at this point
Copy the full SHA 8065e64View commit details
Commits on Jan 26, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 1346329 - Browse repository at this point
Copy the full SHA 1346329View commit details
Commits on Jan 30, 2023
-
Many more fixes/changes per feedback.
This includes: - Fixing image sizing issues - Fixing bullet/numbered list formatting issues - Moving the in-lesson Swahili language switcher to also be behind an admin-configurable per-profile setting - Logging a new event for when the in-lesson language switch button is clicked - Logging a new event for when the user exits a revision card - Updating all events to include app/content/audio language settings for the user - Updating the in-lesson language switch button to only show if the content of a card is available in Swahili - Updating the switch-to-Swahili button's text to be in Swahili when the rest of the strings are in English - Fixing an issue with session ID to ensure it gets reset properly upon profile login - Fixing an issue where switching between tabs in the topic screen wasn't actually logging events for the switches - Introducing a new share button in the learner analytics screen to make it easier to record per-device IDs Miscellaneous other refactors and/or fixes were also done, as needed, and per feedback.
Configuration menu - View commit details
-
Copy full SHA for 39dafc0 - Browse repository at this point
Copy the full SHA 39dafc0View commit details -
Configuration menu - View commit details
-
Copy full SHA for c0dc1a5 - Browse repository at this point
Copy the full SHA c0dc1a5View commit details -
Configuration menu - View commit details
-
Copy full SHA for a1a33d4 - Browse repository at this point
Copy the full SHA a1a33d4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5b220b7 - Browse repository at this point
Copy the full SHA 5b220b7View commit details -
Use latest commit for versioning, instead.
Also, bump version codes to prepare for another Kenya-specific alpha re-release.
Configuration menu - View commit details
-
Copy full SHA for 6eaa68c - Browse repository at this point
Copy the full SHA 6eaa68cView commit details -
Configuration menu - View commit details
-
Copy full SHA for a64d1a2 - Browse repository at this point
Copy the full SHA a64d1a2View commit details -
These were missed in Bazel since test targets were never originally added for them.
Configuration menu - View commit details
-
Copy full SHA for c021017 - Browse repository at this point
Copy the full SHA c021017View commit details
Commits on Jan 31, 2023
-
Configuration menu - View commit details
-
Copy full SHA for c64a91d - Browse repository at this point
Copy the full SHA c64a91dView commit details -
Configuration menu - View commit details
-
Copy full SHA for c4ad811 - Browse repository at this point
Copy the full SHA c4ad811View commit details -
Merge branch 'develop' into assorted-alpha-mr6-fixes
Conflicts: app/src/main/res/values/component_colors.xml
Configuration menu - View commit details
-
Copy full SHA for 3f12d91 - Browse repository at this point
Copy the full SHA 3f12d91View commit details
Commits on Feb 1, 2023
-
Configuration menu - View commit details
-
Copy full SHA for b793d0d - Browse repository at this point
Copy the full SHA b793d0dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4a6b904 - Browse repository at this point
Copy the full SHA 4a6b904View commit details
Commits on Feb 28, 2023
-
Configuration menu - View commit details
-
Copy full SHA for c8eb925 - Browse repository at this point
Copy the full SHA c8eb925View commit details -
Update versions for a Kenya alpha re-release.
Also, fix the version code ordering for KitKat/Lollipop versions (Lollipop should always take priority).
Configuration menu - View commit details
-
Copy full SHA for a8f24c3 - Browse repository at this point
Copy the full SHA a8f24c3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4539b0a - Browse repository at this point
Copy the full SHA 4539b0aView commit details
Commits on Mar 1, 2023
-
Merge branch 'assorted-alpha-mr6-fixes' of github.com:oppia/oppia-and…
…roid into assorted-alpha-mr6-fixes
Configuration menu - View commit details
-
Copy full SHA for 8cd35d9 - Browse repository at this point
Copy the full SHA 8cd35d9View commit details
Commits on Mar 10, 2023
-
Configuration menu - View commit details
-
Copy full SHA for e49a622 - Browse repository at this point
Copy the full SHA e49a622View commit details -
Configuration menu - View commit details
-
Copy full SHA for ca3250e - Browse repository at this point
Copy the full SHA ca3250eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3a8d645 - Browse repository at this point
Copy the full SHA 3a8d645View commit details -
Configuration menu - View commit details
-
Copy full SHA for 245d48a - Browse repository at this point
Copy the full SHA 245d48aView commit details